@ruochunz could you please add a unit test for this case, so that we dont miss it in any future refactors

Hi @soumith , something like this?

Hi,

I think this is fine, but I have a question: we are modifying the behavior of legacy_new_from_data to do something which is by itself quite unexpected I'd say (why are boolean types special in legacy_new_from_data?).
This function doesn't seem to be used anywhere else in the code, is that right?
Do we want to just modify the name of the function to make it explicit that it is specific to indexing, and thus bias the output type to be bool / int64?

Yes, I agree. legacy_new_from_data is not used anywhere else, so it would make sense for it to be renamed to make it explicit that it is specific to indexing.