KEMBAR78
Add a custom profiler configuration option by fwenguang · Pull Request #151656 · pytorch/pytorch · GitHub
Skip to content

Add a custom profiler configuration option #151656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add a custom profiler configuration option #151656

wants to merge 2 commits into from

Conversation

@fwenguang
Copy link
Contributor

We aim to pass some configuration options to our custom Kineto backend via ExperimentalConfig,, so we added a custom_profiler_config parameter.

Requires pytorch/kineto#1077 ,

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151656

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4d47924 with merge base e2c9d8d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 18, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@fwenguang fwenguang marked this pull request as ready for review May 6, 2025 02:34
@fwenguang fwenguang requested a review from sraikund16 as a code owner May 6, 2025 02:34
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 6, 2025
@sraikund16 sraikund16 added enhancement Not as big of a feature, but technically not a bug. Should be easy to fix release notes: profiler release notes category labels May 9, 2025
sraikund16

This comment was marked as outdated.

Sign in to view

sraikund16
sraikund16 reviewed May 9, 2025
View reviewed changes
third_party/kineto Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update to latest submodule

sraikund16
sraikund16 requested changes May 9, 2025
View reviewed changes
Copy link
Contributor

@sraikund16 sraikund16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will approve after submodule updated

@fwenguang fwenguang force-pushed the add_custom_cfg branch 2 times, most recently from 19fde68 to b5bb0da Compare May 12, 2025 02:17
@fwenguang
Copy link
Contributor Author

fwenguang commented May 12, 2025 •
edited
Loading

will approve after submodule updated

The submodule has been updated. Please review, thanks. @sraikund16

@sraikund16
Copy link
Contributor

@fwenguang can you fix the failures?

@fwenguang
Copy link
Contributor Author

@fwenguang can you fix the failures?

@sraikund16 fixed

@fwenguang
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot
Copy link

pytorch-bot bot commented May 28, 2025

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@fwenguang
Copy link
Contributor Author

@sraikund16 kineto patch already upstream. I rebased main, please help handle the workflow.

@fwenguang fwenguang requested a review from sraikund16 June 23, 2025 01:42
@sraikund16
Copy link
Contributor

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased add_custom_cfg onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout add_custom_cfg && git pull --rebase)

@sraikund16
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 30, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sraikund16 sraikund16 sraikund16 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request enhancement Not as big of a feature, but technically not a bug. Should be easy to fix Merged open source release notes: profiler release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fwenguang @sraikund16 @pytorchmergebot @zou3519 @pytorchbot