KEMBAR78
[Cherry-pick] Fix copysign + scalar correctness issue by malfet · Pull Request #153098 · pytorch/pytorch · GitHub
Skip to content

Conversation

malfet
Copy link
Contributor

@malfet malfet commented May 7, 2025

Which consists of three cherry-picks:

malfet added 2 commits May 7, 2025 14:13
But instead of adding it just for MPS backend, add it to OpInfo

Fixes #152582
Pull Request resolved: #152997
Approved by: https://github.com/wdvr

(cherry picked from commit 9919d6b)
@malfet malfet requested review from kulinseth and mruberry as code owners May 7, 2025 21:15
@pytorch-bot
Copy link

pytorch-bot bot commented May 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153098

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Pending, 1 Unrelated Failure

As of commit ab6aba7 with merge base 924a247 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels May 7, 2025
@malfet malfet changed the title malfet/cp 152510 [Cherry-pick] Fix copysign + scalar correctness issue May 7, 2025
They have more than 12Gb memory, but may be running this test causes OOM in CI
Pull Request resolved: #150377
Approved by: https://github.com/atalman
@malfet malfet merged commit 1a3161a into release/2.7 May 9, 2025
184 of 191 checks passed
@github-actions github-actions bot deleted the malfet/cp-152510 branch June 18, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants