KEMBAR78
Only print dde partial fx graph for export by StrongerXi · Pull Request #153218 · pytorch/pytorch · GitHub
Skip to content

Only print dde partial fx graph for export #153218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Return ConstantVariable(None) from WithExitFunctionVariable.exit to prevent NoneType crash inside autocast exception path
merged 2 commits into from
May 14, 2025
Merged

Only print dde partial fx graph for export #153218

merged 2 commits into from
May 14, 2025
+46 −17

Conversation

@StrongerXi
Copy link
Contributor

@StrongerXi StrongerXi commented May 9, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented May 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153218

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures

As of commit b1bb73a with merge base 924a247 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@StrongerXi StrongerXi requested a review from atalman May 9, 2025 00:06
@StrongerXi StrongerXi mentioned this pull request May 9, 2025
Closed
@StrongerXi
[dynamo] Add test to ensure we don't print fx graph upon data depende…
b1bb73a 
…nt graph break

This adds a regression test for #149831, also as part of getting it
cherry-picked into 2.7.1.

ghstack-source-id: fedc9ea
Pull Request resolved: #153416
atalman
atalman approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman atalman merged commit 378a55c into release/2.7 May 14, 2025
304 of 313 checks passed
@atalman atalman mentioned this pull request May 28, 2025
Closed
49 tasks
@github-actions github-actions bot deleted the avoid-spammy-log-for-2.7 branch June 18, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhxchen17 zhxchen17 zhxchen17 approved these changes

@atalman atalman atalman approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@ydwu4 ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

@angelayi angelayi Awaiting requested review from angelayi angelayi is a code owner

Assignees

No one assigned

Labels

ciflow/inductor fx module: dynamo release notes: export

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StrongerXi @zhxchen17 @atalman @facebook-github-bot