KEMBAR78
[CD] Fix the libgomp twice load issue (#150084) by chuanqi129 · Pull Request #153518 · pytorch/pytorch · GitHub
Skip to content

Conversation

chuanqi129
Copy link
Collaborator

Fixes #149422

@chuanqi129 chuanqi129 requested a review from a team as a code owner May 14, 2025 05:35
@pytorch-bot
Copy link

pytorch-bot bot commented May 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153518

Note: Links to docs will display an error until the docs builds have been completed.

❌ 50 New Failures

As of commit c03a137 with merge base 924a247 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label May 14, 2025
@chuanqi129 chuanqi129 added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label May 14, 2025
@pytorch-bot pytorch-bot bot removed the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label May 14, 2025
@chuanqi129 chuanqi129 added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label May 14, 2025
@pytorch-bot pytorch-bot bot removed the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label May 15, 2025
@chuanqi129 chuanqi129 added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label May 15, 2025
@atalman
Copy link
Contributor

atalman commented May 15, 2025

@pytorchmergebot rebase -b release/2.7

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/release/2.7. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased cd_fix_gomp_2.7 onto refs/remotes/origin/release/2.7, please pull locally before adding more changes (for example, via git checkout cd_fix_gomp_2.7 && git pull --rebase)

@pytorch-bot pytorch-bot bot removed the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label May 15, 2025
@chuanqi129 chuanqi129 added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label May 16, 2025
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman atalman merged commit 70518b7 into pytorch:release/2.7 May 20, 2025
436 of 488 checks passed
@atalman
Copy link
Contributor

atalman commented Jun 4, 2025

Validated with 2.7.0 vs 2.7.1:

Almalinux Release 2.7.0

omp_max_threads after loading libgomp.so and libtorch_cpu.so: 1
Traceback (most recent call last):
  File "/pytorch/.ci/pytorch/smoke_test/check_gomp.py", line 74, in <module>
    main()
  File "/pytorch/.ci/pytorch/smoke_test/check_gomp.py", line 68, in main
    raise RuntimeError(
RuntimeError: omp_max_threads is 1. Check whether libgomp.so is loaded twice.

Almalinux Release 2.7.1

python check_gomp.py 
omp_max_threads after loading libgomp.so and libtorch_cpu.so: 16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR open source release notes: releng release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants