[profiler] add more CUDA API for kernel launcher #156016

namgyu-youn · 2025-06-15T10:17:12Z

Add more kernel detection options, resolving TODO

References : NVIDIA - docs

pytorch-bot · 2025-06-15T10:17:16Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156016

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 02b3c4b with merge base 655b3b1 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

namgyu-youn · 2025-06-15T10:21:31Z

@pytorchbot label "release notes: profiler"

Skylion007 · 2025-06-15T14:58:00Z

torch/profiler/_utils.py

-            # TODO: find a better way to identify cudaLaunchKernel
-            return e.name == "cudaLaunchKernel"
+            """Check if the event is a CUDA launch kernel."""
+            launch_patterns = [


Nit: list should be a tuple.

albanD

Thanks!

namgyu-youn · 2025-06-24T04:13:44Z

@pytorchbot merge

pytorch-bot · 2025-06-24T04:13:48Z

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

namgyu-youn · 2025-06-24T04:15:01Z

@pytorchmergebot merge -f "lint is green"

pytorch-bot · 2025-06-24T04:15:05Z

You are not authorized to force merges to this repository. Please use the regular @pytorchmergebot merge command instead

namgyu-youn · 2025-06-24T04:15:32Z

@pytorchmergebot merge

pytorch-bot · 2025-06-24T04:15:36Z

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

namgyu-youn · 2025-06-24T04:20:50Z

@albanD ; Sorry for the distraction. Could you merge this PR?

albanD · 2025-06-24T14:32:11Z

@pytorchbot merge

@namgyu-youn avoid force merging when no test actually ran yet ;)

pytorchmergebot · 2025-06-24T14:34:48Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-06-24T14:50:52Z

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

- Since `is_cuda_kernel` checks for `e.name`, it can raise an AttributeError if `e` does not have a `name` attribute. - For resolving this, we can use `hasattr` to check if `e` has a `name` attribute before accessing it.

torch/profiler/_utils.py

conditioner is not needed Co-authored-by: albanD <desmaison.alban@gmail.com>

albanD · 2025-06-26T13:20:35Z

@pytorchbot merge

pytorchmergebot · 2025-06-26T13:22:55Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-06-26T13:33:36Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

pull / linux-jammy-cpu-py3.10-gcc11-bazel-test / build-and-test (default, 1, 1, linux.4xlarge)

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

namgyu-youn · 2025-06-27T07:08:42Z

@albanD It seems that GitHub Actions failed due to permission in sudo (following), but I am not certain about the reason. Could you lead me for resolving this?

+ echo '    sudo: setrlimit(RLIMIT_STACK): Operation not permitted'
    sudo: setrlimit(RLIMIT_STACK): Operation not permitted
+ echo 'For more details refer to https://github.com/sudo-project/sudo/issues/42'
For more details refer to https://github.com/sudo-project/sudo/issues/42
+ sudo chown -R 1000 /var/lib/jenkins/workspace
Error: Process completed with exit code 22.

namgyu-youn · 2025-07-03T15:21:46Z

@pytorchmergebot merge

namgyu-youn · 2025-07-03T15:23:58Z

@pytorchbot merge

pytorchmergebot · 2025-07-03T15:24:16Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

pytorchmergebot · 2025-07-03T15:26:16Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

add more CUDA API for kernel launcher

f174624

namgyu-youn requested a review from sraikund16 as a code owner June 15, 2025 10:17

pytorch-bot bot added the release notes: profiler release notes category label Jun 15, 2025

pytorchbot added the open source label Jun 15, 2025

Skylion007 reviewed Jun 15, 2025

View reviewed changes

convert launch_patterns list to tuple

016fa04

namgyu-youn changed the title ~~add more CUDA API for kernel launcher~~ [profiler] add more CUDA API for kernel launcher Jun 17, 2025

namgyu-youn requested a review from Skylion007 June 17, 2025 06:18

colesbury requested a review from albanD June 17, 2025 12:25

colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 17, 2025

albanD approved these changes Jun 23, 2025

View reviewed changes

fix SyntexError

5d9fe8a

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 24, 2025

pytorchmergebot added the merging label Jun 24, 2025

pytorchmergebot removed the merging label Jun 24, 2025

fix AttributeError for CUDA events in profiler

abdc2a6

- Since `is_cuda_kernel` checks for `e.name`, it can raise an AttributeError if `e` does not have a `name` attribute. - For resolving this, we can use `hasattr` to check if `e` has a `name` attribute before accessing it.

pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Jun 24, 2025

namgyu-youn requested a review from albanD June 24, 2025 18:42

albanD reviewed Jun 25, 2025

View reviewed changes

torch/profiler/_utils.py Outdated Show resolved Hide resolved

update utils functions for suggested change

02b3c4b

conditioner is not needed Co-authored-by: albanD <desmaison.alban@gmail.com>

namgyu-youn requested a review from albanD June 26, 2025 03:17

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 26, 2025

pytorchmergebot added the merging label Jun 26, 2025

pytorchmergebot removed the merging label Jun 26, 2025

pytorchmergebot added the merging label Jul 3, 2025

pytorchmergebot added the Merged label Jul 3, 2025

pytorchmergebot closed this in f17f658 Jul 3, 2025

namgyu-youn deleted the profiler_refactor branch July 3, 2025 15:27

pytorchmergebot removed the merging label Jul 3, 2025

[profiler] add more CUDA API for kernel launcher #156016

[profiler] add more CUDA API for kernel launcher #156016

Uh oh!

Conversation

namgyu-youn commented Jun 15, 2025

Uh oh!

pytorch-bot bot commented Jun 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156016

✅ No Failures

Uh oh!

namgyu-youn commented Jun 15, 2025

Uh oh!

Skylion007 Jun 15, 2025

Choose a reason for hiding this comment

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

namgyu-youn commented Jun 24, 2025

Uh oh!

pytorch-bot bot commented Jun 24, 2025

Uh oh!

namgyu-youn commented Jun 24, 2025

Uh oh!

pytorch-bot bot commented Jun 24, 2025

Uh oh!

namgyu-youn commented Jun 24, 2025

Uh oh!

pytorch-bot bot commented Jun 24, 2025

Uh oh!

namgyu-youn commented Jun 24, 2025

Uh oh!

albanD commented Jun 24, 2025

Uh oh!

pytorchmergebot commented Jun 24, 2025

Merge started

Uh oh!

pytorchmergebot commented Jun 24, 2025

Merge failed

Uh oh!

Uh oh!

albanD commented Jun 26, 2025

Uh oh!

pytorchmergebot commented Jun 26, 2025

Merge started

Uh oh!

pytorchmergebot commented Jun 26, 2025

Merge failed

Uh oh!

namgyu-youn commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

namgyu-youn commented Jul 3, 2025

Uh oh!

namgyu-youn commented Jul 3, 2025

Uh oh!

pytorchmergebot commented Jul 3, 2025

Uh oh!

pytorchmergebot commented Jul 3, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pytorch-bot bot commented Jun 15, 2025 •

edited

Loading

namgyu-youn commented Jun 27, 2025 •

edited

Loading