[ONNX] Update default opset to 18 #156023
Closed
+10
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinchuby
requested review from
shubhambhokare1,
titaiwangms and
wschin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156023
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 423f1ba with merge base 655b3b1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: onnx
justinchuby
added
module: onnx
Skylion007
approved these changes
Jun 15, 2025
Skylion007
reviewed
Jun 15, 2025
|
|
||
| const static int kInvalidOpsetVersion = -1; | ||
| const static int kMainOpsetVersion = 20; | ||
| const static int kMainOpsetVersion = 23; |
There was a problem hiding this comment.
Ni: why isn't this constexpr?
Skylion007
approved these changes
Jun 15, 2025
justinchuby
commented
Jun 16, 2025
justinchuby
commented
Jun 16, 2025
justinchuby
commented
Jun 16, 2025
justinchuby
commented
Jun 16, 2025
justinchuby
commented
Jun 16, 2025
justinchuby
commented
Jun 16, 2025
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
titaiwangms
reviewed
Jun 16, 2025
79 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update default opset for the torchscript exporter to 18 to match the dynamo exporter, because support was actaully added and tested in #118828. In the next version we should plan to update to opset 21 or higher. This change also removes the hard limit on the torchscript exporter for more flexibility.