KEMBAR78
Fixes issue #156414: Fixes bug in implementation of _combine_histograms. by Akabbaj · Pull Request #156457 · pytorch/pytorch · GitHub
Skip to content

Fixes issue #156414: Fixes bug in implementation of _combine_histograms. #156457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixes issue #156414: Fixes bug in implementation of _combine_histograms. #156457

wants to merge 1 commit into from

Conversation

@Akabbaj
Copy link
Contributor

@Akabbaj Akabbaj commented Jun 20, 2025

Fixes #156414

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156457

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8184e5b with merge base 2625c70 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 20, 2025 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 20, 2025
@jerryzh168
Copy link
Contributor

thanks can you help fix in https://github.com/pytorch/ao/blob/4e3d0198f93602d88db9d5ba6bb6020454fc5fde/torchao/quantization/pt2e/observer.py#L1251 as well

@jerryzh168 jerryzh168 requested a review from TiRune June 21, 2025 00:00
jerryzh168
jerryzh168 approved these changes Jun 21, 2025
View reviewed changes
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems right to me, but I'll ask @TiRune take a look as well

@cyyever
Copy link
Collaborator

cyyever commented Jun 29, 2025

@pytorchmergebot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 29, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

@TiRune TiRune Awaiting requested review from TiRune

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: AO frontend release notes: quantization release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A possible bug in HistogramObserver._combine_histograms()

6 participants

@Akabbaj @jerryzh168 @cyyever @pytorchmergebot @pytorchbot @mikaylagawarecki