KEMBAR78
load inline user overridable gencode by msaroufim · Pull Request #156850 · pytorch/pytorch · GitHub
Skip to content

load inline user overridable gencode #156850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

load inline user overridable gencode #156850

wants to merge 15 commits into from

Conversation

@msaroufim
Copy link
Member

@msaroufim msaroufim commented Jun 25, 2025 •
edited
Loading

Fixes #156815

As far as testing goes

  • I tried to use cuobjdump but that was kinda goofy bccd939 the problem was that the name of the cubin will have a single gencode always
  • Another idea was to read stderr and check that the right amount of gencodes is there 0beadc0 this helped a lot to convince me locally that this test works, the test passed on my dev gpu but was failing in CI and I suspect it's because of a bad interaction with subprocesses
  • Last approach was to have a simpler unit test to check which flags get added by default, this is not as comprehensive as the previous ideas but it works and is fast so will opt for this since I'm convinced testing is working per my own experiments and customers

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156850

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (7 Unrelated Failures)

As of commit 23881ee with merge base 3f920f3 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@msaroufim msaroufim removed request for ezyang and fmassa June 25, 2025 17:23
@msaroufim msaroufim added the topic: not user facing topic category label Jun 25, 2025
@malfet malfet added release notes: python_frontend python frontend release notes category topic: bug fixes topic category and removed topic: not user facing topic category labels Jun 25, 2025
@malfet
Copy link
Contributor

malfet commented Jun 25, 2025

@msaroufim not sure why you've added not user facing as it's clearly a bugfix (and we may even want to cherry-pick it into 2.8 release, but please add test)

@msaroufim msaroufim changed the title load inline explicit gencode load inline user overridable gencode Jun 25, 2025
@msaroufim
Copy link
Member Author

msaroufim commented Jun 26, 2025 •
edited
Loading

6 failures seem to be related to inductor/test_distributed_patterns

@msaroufim
Copy link
Member Author

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 26, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 6 checks: pull / linux-jammy-py3.13-clang12 / test (default, 1, 5, lf.linux.4xlarge), pull / linux-jammy-py3.9-gcc11 / test (default, 1, 5, lf.linux.2xlarge), pull / linux-jammy-py3.9-clang12 / test (default, 1, 5, lf.linux.4xlarge), pull / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 1, 5, lf.linux.4xlarge.nvidia.gpu), pull / linux-jammy-cuda12.8-py3.10-gcc11-sm89 / test (default, 1, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu), pull / linux-jammy-py3.10-clang18-asan / test (default, 1, 6, lf.linux.4xlarge)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the msaroufim/gencode branch July 27, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: python_frontend python frontend release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

load_inline forcibly adds legacy -gencode flags and cannot be overridden, preventing use of newer compute capabilities

3 participants

@msaroufim @malfet @pytorchmergebot