KEMBAR78
[MPS] Fix batch norm incorrect gradient by Isalia20 · Pull Request #156867 · pytorch/pytorch · GitHub
Skip to content

[MPS] Fix batch norm incorrect gradient #156867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[MPS] Fix batch norm incorrect gradient #156867

wants to merge 1 commit into from

Conversation

@Isalia20
Copy link
Collaborator

@Isalia20 Isalia20 commented Jun 25, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156867

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 5d70af7 with merge base 029e2b0 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Jun 25, 2025
@Isalia20 Isalia20 added module: mps Related to Apple Metal Performance Shaders framework ciflow/mps Run MPS tests (subset of trunk) labels Jun 25, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 25, 2025

To add the ciflow label ciflow/mps please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/mps Run MPS tests (subset of trunk) label Jun 25, 2025
malfet
malfet approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@malfet malfet added the ciflow/mps Run MPS tests (subset of trunk) label Jun 25, 2025
@malfet
Copy link
Contributor

malfet commented Jun 25, 2025

@pytorchbot merge -f "Lint + MPS are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged module: mps Related to Apple Metal Performance Shaders framework open source release notes: mps Release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When using Apple MPS, the bias of BatchNorm1d becomes extremely large.

4 participants

@Isalia20 @malfet @pytorchmergebot @pytorchbot