KEMBAR78
Remove unnecessary warnings during the ATen compilation process. by thenumberouscode · Pull Request #157703 · pytorch/pytorch · GitHub
Skip to content

Remove unnecessary warnings during the ATen compilation process. #157703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove unnecessary warnings during the ATen compilation process. #157703

wants to merge 1 commit into from

Conversation

@thenumberouscode
Copy link
Contributor

@thenumberouscode thenumberouscode commented Jul 7, 2025 •
edited by pytorch-bot bot
Loading

Comparing uint32_t(num_threads()) with int(kCUDABlockReduceMaxThreads) always results in a compilation warning. Just change the return type of kCUDABlockReduceMaxThreads to uint32_t to avoid it.
Fixes #157701

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157703

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 087a333 with merge base d26ca5d (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 7, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: thenumberouscode / name: zyl_keep_moving (087a333)

@pytorch-bot pytorch-bot bot added module: cpu CPU specific problem (e.g., perf, algorithm) module: inductor labels Jul 7, 2025
@thenumberouscode thenumberouscode force-pushed the bugfix_embedding_renorm_cuda_ branch from 91d6537 to abe79cf Compare July 7, 2025 09:20
@pytorch-bot pytorch-bot bot added the release notes: cuda release notes category label Jul 7, 2025
@thenumberouscode
Change the return type of kCUDABlockReduceMaxThreads from int to uint…
087a333 
…32_t to avoid unnecessary warnings in embedding_renorm_cuda_.
@thenumberouscode thenumberouscode force-pushed the bugfix_embedding_renorm_cuda_ branch from abe79cf to 087a333 Compare July 7, 2025 09:33
malfet
malfet approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change almost looks good, but it would be nice if you'd followed thru and actually changed kCUDABlockReduceMaxThreads to uint32_t as you've mentioned in PR description

Skylion007
Skylion007 approved these changes Jul 7, 2025
View reviewed changes
Copy link
Collaborator

@Skylion007 Skylion007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, the better fix would be to fix the function return type

@thenumberouscode
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 7, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@thenumberouscode
Copy link
Contributor Author

This change almost looks good, but it would be nice if you'd followed thru and actually changed kCUDABlockReduceMaxThreads to uint32_t as you've mentioned in PR description

Yeah, you were right. but I am so excited to be a contributor of pytorch, I can not wait even one second. hahaha, This is my first pr. thanks all guys.

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Remote end closed connection without response

Details for Dev Infra team Raised by workflow job

@thenumberouscode
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@malfet malfet malfet approved these changes

@eqy eqy Awaiting requested review from eqy eqy is a code owner

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: inductor open source release notes: cuda release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compiling the pytorch project produces unnecessary integer comparison warnings, which can lead to a poor user experience.

5 participants

@thenumberouscode @pytorchmergebot @Skylion007 @malfet @pytorchbot