Documentation Fix: Torch gather broadcasting #157920
Conversation
… specific backends
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157920
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c4207fb with merge base e3f2597 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: python_frontend
|
@albanD Please let me know if these changes are sufficient. Thank you |
There was a problem hiding this comment.
From checking locally, this is not actually true.
It indeed doesn't broadcast and only the error checking is disabled for empty Tensor (nelement() == 0).
You should update the doc with that instead: keep what is there but add a line saying that for empty indices, we always return an empty output with the same shape without further error checking
morrison-turnansky
force-pushed
the
issue-157425-gather-broadcast
branch
from
0edd630 to
c4207fb
Compare
|
@albanD I have updated the PR according to your comments. |
|
@pytorchbot merge |
|
PR targets viable/strict rather than main, refusing merge request |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
4 participants
updated torch gather docs to reflect proper broadcasting behavior for specific backends
Fixes #157425