KEMBAR78
Documentation Fix: torch.tensor.scatter_ docs by morrison-turnansky · Pull Request #157929 · pytorch/pytorch · GitHub
Skip to content

Conversation

@morrison-turnansky
Copy link
Contributor

updated torch.tensor.scatter_ docs to reflect proper broadcasting behavior

Fixes #157419

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157929

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4b6fd57 with merge base e3f2597 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@morrison-turnansky
Copy link
Contributor Author

morrison-turnansky commented Jul 9, 2025

@albanD I made the equivalent change as the torch gather issue #157425. Let me know if you want any additional changes.

@morrison-turnansky
Copy link
Contributor Author

I updated the PR after some local testing following your lead. The case is similar to gather, except the original tensor is returned when index is empty.

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@albanD
Copy link
Collaborator

albanD commented Jul 10, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 10, 2025
@pytorchmergebot
Copy link
Collaborator

PR targets viable/strict rather than main, refusing merge request

@morrison-turnansky morrison-turnansky changed the base branch from viable/strict to main July 10, 2025 17:47
@morrison-turnansky
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 10, 2025

Didn't find following labels among repository labels: release,notes:,python_frontend

@morrison-turnansky
Copy link
Contributor Author

@pytorchbot label "release notes: python_frontend"

@pytorch-bot pytorch-bot bot added the release notes: python_frontend python frontend release notes category label Jul 10, 2025
@morrison-turnansky
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@morrison-turnansky morrison-turnansky deleted the issue-157419-scatter-docs branch October 3, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: python_frontend python frontend release notes category

Projects

None yet

4 participants