Add bindings for .cpu() & .cuda() to script #15904
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
|
Looks good. I would just add a comment about the aliasing thing. |
suo
approved these changes
Jan 10, 2019
suo
reviewed
Jan 10, 2019
test/test_jit.py
Outdated
There was a problem hiding this comment.
maybe assert device just to sanity check
|
I'll add a comment. I think the solution here would be to peephole optimize .cpu() in shape analysis if we have the Tensor device type. That way we remove no-ops and don't complicate shape analysis. |
eellison
force-pushed
the
to_cpu_to_cuda
branch
from
0ae539b to
bd21a42
Compare
There was a problem hiding this comment.
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding bindings for .cpu() and .cuda() to script.
It's worth noting that if the device remains unchanged, than the returned tensor aliases the input, but if it does change than they do not alias each other.