Fix the dropout onnx symbolic, and ensure all exported models in test_operators.py are eval mode #16547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houseroad
force-pushed
the
fix_onnx_dropout
branch
from
0092e11 to
31dd2df
Compare
squeeze two lines into one
houseroad
force-pushed
the
fix_onnx_dropout
branch
from
31dd2df to
0c5d433
Compare
There was a problem hiding this comment.
@dzhulgakov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Good catch. Looks like the bug was there from the very beginning - even before #10384 refactoring |
dzhulgakov
approved these changes
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In eval mode, skip dropout operator in onnx exporter.