Access profiler from cpp #16580
Access profiler from cpp #16580
Conversation
facebook-github-bot
added
the
oncall: jit
torch/csrc/autograd/profiler.h
Outdated
There was a problem hiding this comment.
This file needs #include <fstream> to build on my devserver
There was a problem hiding this comment.
@zdevito has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@zdevito has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
|
||
| RecordProfile::~RecordProfile() { | ||
| thread_event_lists event_lists = disableProfiler(); | ||
| std::vector<Event*> events; |
There was a problem hiding this comment.
This is kind of unnecessary. We could simply have this double loop inside processEvents and avoid allocating as many pointers as we have events
There was a problem hiding this comment.
Plus you don't even reserve memory, meaning that we will keep reallocating the storage many many times
| } | ||
|
|
||
| void RecordProfile::init() { | ||
| enableProfiler(ProfilerState::CPU); |
There was a problem hiding this comment.
I guess it would be nice to take this as a constructor argument too
| } | ||
|
|
||
| void RecordProfile::processEvents(const std::vector<Event*>& events) { | ||
| AT_CHECK(out_, "could not open file"); |
There was a problem hiding this comment.
nit: check in constructor (when the file is actually opened)?
| break; | ||
| } | ||
| } | ||
| AT_CHECK(start, "could not find start?"); |
5 participants
@jamesr66a