[jit] Better error when using a constant tensor #16724
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
driazati
force-pushed
the
const_ten_error
branch
2 times, most recently
from
0b8546d to
89bf8df
Compare
driazati
force-pushed
the
const_ten_error
branch
from
89bf8df to
52053d2
Compare
suo
approved these changes
Feb 5, 2019
|
Interesting. So it's not allowed to have a tensor in |
|
Not at the moment: Line 911 in e2d3a3f I'm guessing most use cases are covered just by registering a buffer, but I don't really see any reason why we couldn't also allow constant tensors |
|
Allowing tensors in |
There was a problem hiding this comment.
@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@suo how do we enforce this for e.g. int lists then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16284