C++ Frontend: adding two distributed samples (Random and Sequential) #16910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzhu1900
reviewed
Feb 9, 2019
xzhu1900
reviewed
Feb 9, 2019
xzhu1900
approved these changes
Feb 12, 2019
apaszke
reviewed
Feb 13, 2019
jaliyae
force-pushed
the
jaliyae/distributed_samplers
branch
from
18e07e3 to
37f601e
Compare
|
Fixed all review suggestions. |
apaszke
reviewed
Feb 15, 2019
|
Fixed the review comments and hopefully the windows build issue. |
soumith
force-pushed
the
jaliyae/distributed_samplers
branch
from
450947e to
0b71056
Compare
|
Windows CI is still failing. |
apaszke
reviewed
Feb 17, 2019
|
Fix the review comments. The checkpointing mechanism is probably need to change once we have a checkpoint mechanism in the dataloader. I don't think we need to finalize it for this PR. |
soumith
approved these changes
Feb 19, 2019
soumith
changed the title
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding two distrbuted samplers, Random and Sequential to the mix. Similar to python counterpart, DistributedSampler introduces a new method
set_epoch(size_t epoch)which can be use to shuffle data determinstically between distributed processes.