Further improvements of nn.container docs #17731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishwakftw
reviewed
Mar 7, 2019
| or another :class:`~torch.nn.ParameterDict` (the argument to | ||
| :meth:`~torch.nn.ParameterDict.update`). | ||
| Note that :meth:`~torch.nn.ParameterDict.update` with other unordered mapping |
There was a problem hiding this comment.
Could this be added in a note-block?
There was a problem hiding this comment.
It sort of goes together with the previous paragraph, so I didn't make it a .. note::
zou3519
reviewed
Mar 10, 2019
torch/nn/modules/container.py
Outdated
| :meth:`~torch.nn.ParameterDict.update`). | ||
| Note that :meth:`~torch.nn.ParameterDict.update` with other unordered mapping | ||
| types (e.g., Python's plain ``dict``) doesn't not preserve order of the |
zou3519
reviewed
Mar 10, 2019
|
|
||
| if isinstance(parameters, container_abcs.Mapping): | ||
| if isinstance(parameters, OrderedDict): | ||
| if isinstance(parameters, (OrderedDict, ParameterDict)): |
There was a problem hiding this comment.
Interesting, didn't know you could do this
There was a problem hiding this comment.
yeah it takes in a tuple :D
zou3519
approved these changes
Mar 10, 2019
|
@zou3519 Thanks! I've fixed the typo. Hopefully lint passes as I edited on github UI directly. |
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.