KEMBAR78
Upgrade to pybind11 2.4.3 by ezyang · Pull Request #31920 · pytorch/pytorch · GitHub
Skip to content

Upgrade to pybind11 2.4.3 #31920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Upgrade to pybind11 2.4.3 #31920

wants to merge 1 commit into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Jan 7, 2020

Fixes #31362

Signed-off-by: Edward Z. Yang ezyang@fb.com

@ezyang
Upgrade to pybind11 2.4.3
d4bc5ae 
Fixes pytorch#31362

Signed-off-by: Edward Z. Yang <ezyang@fb.com>
facebook-github-bot
facebook-github-bot reviewed Jan 7, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@kostmo
Copy link
Member

kostmo commented Jan 7, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit d4bc5ae:

  • 1/2 broken upstream at merge base 5cc62f2 since Jan 07

    You may want to rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch origin viable/strict
git rebase --onto viable/strict $(git merge-base origin/master HEAD)

    If your commit is older than viable/strict:

    git fetch origin viable/strict
git rebase viable/strict

    Check out the recency history of this "viable master" tracking branch.

  • 1/2 failures introduced in this PR

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

🕵️ 1 new failure recognized by patterns

The following build failures do not appear to be due to upstream breakage:

See CircleCI build pytorch_linux_xenial_py3_clang5_asan_test (1/1)

Step: "Test" (full log | pattern match details)

Jan 07 22:35:11 RuntimeError: test_cpp_extensions failed! 
Jan 07 22:35:10 Ran 31 tests in 275.991s 
Jan 07 22:35:10  
Jan 07 22:35:10 FAILED (errors=3, skipped=7) 
Jan 07 22:35:10  
Jan 07 22:35:10 Generating XML reports... 
Jan 07 22:35:11 Traceback (most recent call last): 
Jan 07 22:35:11   File "test/run_test.py", line 456, in <module> 
Jan 07 22:35:11     main() 
Jan 07 22:35:11   File "test/run_test.py", line 449, in main 
Jan 07 22:35:11     raise RuntimeError(message) 
Jan 07 22:35:11 RuntimeError: test_cpp_extensions failed! 
Jan 07 22:35:11 + cleanup 
Jan 07 22:35:11 + retcode=1 
Jan 07 22:35:11 + set +x 
Jan 07 22:35:11 =================== sccache compilation log =================== 
Jan 07 22:35:11 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Jan 07 22:35:11 Compile requests                 36 
Jan 07 22:35:11 Compile requests executed        19 
Jan 07 22:35:11 Cache hits                        1 
Jan 07 22:35:11 Cache misses                     17 
Jan 07 22:35:11 Cache timeouts                    0
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 1 time.

@ezyang
Copy link
Contributor Author

ezyang commented Jan 8, 2020

It looks like somehow this is causing a regression in ASAN:

n 07 22:35:10 ======================================================================
Jan 07 22:35:10 ERROR [21.577s]: test_cpp_frontend_module_has_same_output_as_python (__main__.TestCppExtension)
Jan 07 22:35:10 ----------------------------------------------------------------------
Jan 07 22:35:10 Traceback (most recent call last):
Jan 07 22:35:10   File "/var/lib/jenkins/workspace/test/common_utils.py", line 310, in wrapper
Jan 07 22:35:10     fn(*args, **kwargs)
Jan 07 22:35:10   File "test_cpp_extensions.py", line 490, in test_cpp_frontend_module_has_same_output_as_python
Jan 07 22:35:10     verbose=True,
Jan 07 22:35:10   File "/opt/conda/lib/python3.6/site-packages/torch/utils/cpp_extension.py", line 679, in load
Jan 07 22:35:10     is_python_module)
Jan 07 22:35:10   File "/opt/conda/lib/python3.6/site-packages/torch/utils/cpp_extension.py", line 876, in _jit_compile
Jan 07 22:35:10     return _import_module_from_library(name, build_directory, is_python_module)
Jan 07 22:35:10   File "/opt/conda/lib/python3.6/site-packages/torch/utils/cpp_extension.py", line 1092, in _import_module_from_library
Jan 07 22:35:10     return imp.load_module(module_name, file, path, description)
Jan 07 22:35:10   File "/opt/conda/lib/python3.6/imp.py", line 243, in load_module
Jan 07 22:35:10     return load_dynamic(name, filename, file)
Jan 07 22:35:10   File "/opt/conda/lib/python3.6/imp.py", line 343, in load_dynamic
Jan 07 22:35:10     return _load(spec)
Jan 07 22:35:10   File "<frozen importlib._bootstrap>", line 684, in _load
Jan 07 22:35:10   File "<frozen importlib._bootstrap>", line 658, in _load_unlocked
Jan 07 22:35:10   File "<frozen importlib._bootstrap>", line 571, in module_from_spec
Jan 07 22:35:10   File "<frozen importlib._bootstrap_external>", line 922, in create_module
Jan 07 22:35:10   File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
Jan 07 22:35:10 ImportError: generic_type: type "Net" referenced unknown base type "torch::nn::Module"

We'll have to figure out why this is happening.

This was referenced Oct 12, 2020
Closed
Open
@henryiii henryiii mentioned this pull request Oct 17, 2020
Merged
@pytorchbot
Copy link
Collaborator

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
Stale pull requests will automatically be closed 30 days after being marked Stale

@github-actions github-actions bot closed this May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Assignees

No one assigned

Labels

cla signed Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sklearn and pytorch incompatibility issue

4 participants

@ezyang @kostmo @pytorchbot @facebook-github-bot