KEMBAR78
Document monitored barrier by rohan-varma · Pull Request #58322 · pytorch/pytorch · GitHub
Skip to content

Conversation

@rohan-varma
Copy link
Contributor

Will not land before the release, but would be good to have this function documented in master for its use in distributed debugability.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 14, 2021

💊 CI failures summary and remediations

As of commit ca6df74 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_bionic_py3_6_clang9_noarch_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 15 01:17:35 RuntimeError: test_linalg failed!
May 15 01:17:35 FAILED (errors=12, skipped=1385)
May 15 01:17:35 
May 15 01:17:35 Generating XML reports...
May 15 01:17:35 Generated XML report: test-reports/python-unittest/test_linalg/TEST-TestLinalgCPU-20210515011504.xml
May 15 01:17:35 Generated XML report: test-reports/python-unittest/test_linalg/TEST-TestLinalgMETA-20210515011504.xml
May 15 01:17:35 Traceback (most recent call last):
May 15 01:17:35   File "test/run_test.py", line 1170, in <module>
May 15 01:17:35     main()
May 15 01:17:35   File "test/run_test.py", line 1149, in main
May 15 01:17:35     raise RuntimeError(err_message)
May 15 01:17:35 RuntimeError: test_linalg failed!
May 15 01:17:36 =================== sccache compilation log ===================
May 15 01:17:36 
May 15 01:17:36 real	8m56.322s
May 15 01:17:36 user	10m3.836s
May 15 01:17:36 sys	0m44.657s
May 15 01:17:36 + cleanup
May 15 01:17:36 + retcode=1
May 15 01:17:36 + set +x
May 15 01:17:36 =========== If your build fails, please take a look at the log above for possible reasons ===========
May 15 01:17:36 Compile requests                      30

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label May 14, 2021
@codecov
Copy link

codecov bot commented May 15, 2021

Codecov Report

Merging #58322 (e97421e) into master (8ac0917) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head e97421e differs from pull request most recent head ca6df74. Consider uploading reports for the commit ca6df74 to get more accurate results

@@            Coverage Diff             @@
##           master   #58322      +/-   ##
==========================================
- Coverage   76.77%   76.74%   -0.03%     
==========================================
  Files        1987     1987              
  Lines      198634   198634              
==========================================
- Hits       152500   152450      -50     
- Misses      46134    46184      +50     

@wayi1
Copy link
Contributor

wayi1 commented May 15, 2021

Will not land before the release, but would be good to have this function documented in master for its use in distributed debugability.

The branch cut is delayed to next Monday. You can land it before the release if you want.

@rohan-varma
Copy link
Contributor Author

Will not land before the release, but would be good to have this function documented in master for its use in distributed debugability.

The branch cut is delayed to next Monday. You can land it before the release if you want.

The main reason I'd prefer to land this after branch cut is because this feature is for debugability which has not been reviewed as part of a release yet, so keeping it in master-only for now seems like the best option. What do you think?

@facebook-github-bot
Copy link
Contributor

@rohan-varma has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@rohan-varma merged this pull request in 071d49a.

@github-actions github-actions bot deleted the doc_monitored_barrier branch February 11, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants