-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Document monitored barrier #58322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document monitored barrier #58322
Conversation
💊 CI failures summary and remediationsAs of commit ca6df74 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Codecov Report
@@ Coverage Diff @@
## master #58322 +/- ##
==========================================
- Coverage 76.77% 76.74% -0.03%
==========================================
Files 1987 1987
Lines 198634 198634
==========================================
- Hits 152500 152450 -50
- Misses 46134 46184 +50 |
The branch cut is delayed to next Monday. You can land it before the release if you want. |
The main reason I'd prefer to land this after branch cut is because this feature is for debugability which has not been reviewed as part of a release yet, so keeping it in master-only for now seems like the best option. What do you think? |
|
@rohan-varma has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@rohan-varma merged this pull request in 071d49a. |
Will not land before the release, but would be good to have this function documented in master for its use in distributed debugability.