KEMBAR78
[numpy] mvlgamma: int -> float promotion by kshitij12345 · Pull Request #59934 · pytorch/pytorch · GitHub
Skip to content

[numpy] mvlgamma: int -> float promotion #59934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[numpy] mvlgamma: int -> float promotion #59934

wants to merge 2 commits into from
+19 −8

Conversation

@kshitij12345
Copy link
Collaborator

@kshitij12345 kshitij12345 commented Jun 14, 2021 •
edited
Loading

Reference: #42515

Last int->float promotion as per the tracker!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 14, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 339ad9e (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_bionic_py3_8_gcc9_coverage_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 14 12:12:36 ERROR [2.038s]: test_forward_sy...ipt (__main__.TensorPipeRemoteModuleTestWithSpawn) 
Jun 14 12:12:15 [W tensorpipe_agent.cpp:698] RPC agent for worker2 won't send response to request #27 to worker1, as the agent is shutting down
Jun 14 12:12:16 ok (16.409s)
Jun 14 12:12:20   test_set_and_get_num_worker_threads (__main__.TensorPipeTensorPipeAgentRpcTestWithSpawn) ... ok (3.665s)
Jun 14 12:12:23   test_tensorpipe_options_throw_on_timedelta_timeout (__main__.TensorPipeTensorPipeAgentRpcTestWithSpawn) ... ok (3.263s)
Jun 14 12:12:27   test_tensorpipe_set_default_timeout (__main__.TensorPipeTensorPipeAgentRpcTestWithSpawn) ... ok (3.569s)
Jun 14 12:12:30   test_create_remote_module_from_module_rref (__main__.TensorPipeThreeWorkersRemoteModuleTestWithSpawn) ... ok (3.258s)
Jun 14 12:12:33   test_send_remote_module_over_the_wire (__main__.TensorPipeThreeWorkersRemoteModuleTestWithSpawn) ... ok (3.066s)
Jun 14 12:12:36   test_send_remote_module_over_the_wire_script_not_supported (__main__.TensorPipeThreeWorkersRemoteModuleTestWithSpawn) ... ok (2.968s)
Jun 14 12:12:36 
Jun 14 12:12:36 ======================================================================
Jun 14 12:12:36 ERROR [2.038s]: test_forward_sync_script (__main__.TensorPipeRemoteModuleTestWithSpawn)
Jun 14 12:12:36 ----------------------------------------------------------------------
Jun 14 12:12:36 Traceback (most recent call last):
Jun 14 12:12:36   File "/opt/conda/lib/python3.8/site-packages/torch/testing/_internal/common_distributed.py", line 398, in wrapper
Jun 14 12:12:36     self._join_processes(fn)
Jun 14 12:12:36   File "/opt/conda/lib/python3.8/site-packages/torch/testing/_internal/common_distributed.py", line 590, in _join_processes
Jun 14 12:12:36     self._check_return_codes(elapsed_time)
Jun 14 12:12:36   File "/opt/conda/lib/python3.8/site-packages/torch/testing/_internal/common_distributed.py", line 633, in _check_return_codes
Jun 14 12:12:36     raise RuntimeError(error)
Jun 14 12:12:36 RuntimeError: Process 0 exited with error code 10 and exception:
Jun 14 12:12:36 Traceback (most recent call last):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@kshitij12345 kshitij12345 requested a review from mruberry June 14, 2021 14:59
@kshitij12345 kshitij12345 marked this pull request as ready for review June 14, 2021 14:59
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 14, 2021
@kshitij12345 kshitij12345 added the module: numpy Related to numpy support, and also numpy compatibility of our operators label Jun 15, 2021
mruberry
mruberry approved these changes Jun 16, 2021
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@facebook-github-bot
Copy link
Contributor

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mruberry merged this pull request in 3288c9d.

@kshitij12345 kshitij12345 deleted the develop/numpy/int-float-promotion-mvlgamma branch June 17, 2021 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

Assignees

No one assigned

Labels

cla signed Merged module: numpy Related to numpy support, and also numpy compatibility of our operators open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kshitij12345 @facebook-github-bot @mruberry @soulitzer @pytorchbot