KEMBAR78
add output_process_fn_grad before sum().backward() by walterddr · Pull Request #59971 · pytorch/pytorch · GitHub
Skip to content

Conversation

@walterddr
Copy link
Contributor

This should fix to_sparse test issue.

Test Plan:
CI

Also: directly examine the RuntimeError thrown from test_unsupported_backward

  • Before:
NotImplementedError: Could not run 'aten::sum' with arguments from the 'SparseCPU' backend.
  • After:
to_dense() not supported for float16 on CPU

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 14, 2021

💊 CI failures summary and remediations

As of commit fb952d2 (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

1 failure not recognized by patterns:

Job Step Action
GitHub Actions Linux CI (pytorch-linux-xenial-py3.6-gcc5.4) / calculate-docker-image Checkout PyTorch 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@walterddr merged this pull request in 5b9fced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants