KEMBAR78
DOC Adds LSTM docs for defined variables when bidirectional=True by thomasjpfan · Pull Request #60120 · pytorch/pytorch · GitHub
Skip to content

DOC Adds LSTM docs for defined variables when bidirectional=True #60120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

DOC Adds LSTM docs for defined variables when bidirectional=True #60120

wants to merge 4 commits into from

Conversation

@thomasjpfan
Copy link
Contributor

Fixes #59332

@thomasjpfan thomasjpfan added module: docs Related to our documentation, both in docs/ and docblocks module: nn Related to torch.nn triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jun 16, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 16, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit eaa193d (more details on the Dr. CI page and at hud.pytorch.org/pr/60120):

  • 3/3 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_cuda11_1_cudnn8_py3_gcc7_test1 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 18 22:17:35 ERROR [0.001s]: test_multitenancy (__main__.TCPStoreTest) 
Jun 18 22:17:33 /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/__init__.py:163: UserWarning: RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. PyTorch v1.9 will be the last release that carries PROCESS_GROUP RPC backend. If you have concerns or suggestions please comment in https://github.com/pytorch/pytorch/issues/55615
Jun 18 22:17:33   "RPC was initialized with the PROCESS_GROUP backend which is "
Jun 18 22:17:33 ok (0.023s)
Jun 18 22:17:33   test_multi_worker_with_fixed_world_size (__main__.TCPStoreTest) ... ok (0.004s)
Jun 18 22:17:33   test_multi_worker_with_nonfixed_world_size (__main__.TCPStoreTest) ... ok (0.007s)
Jun 18 22:17:33   test_multitenancy (__main__.TCPStoreTest) ... ERROR (0.001s)
Jun 18 22:17:35   test_numkeys_delkeys (__main__.TCPStoreTest) ... ok (2.007s)
Jun 18 22:17:35   test_set_get (__main__.TCPStoreTest) ... ok (0.003s)
Jun 18 22:17:35 
Jun 18 22:17:35 ======================================================================
Jun 18 22:17:35 ERROR [0.001s]: test_multitenancy (__main__.TCPStoreTest)
Jun 18 22:17:35 ----------------------------------------------------------------------
Jun 18 22:17:35 Traceback (most recent call last):
Jun 18 22:17:35   File "distributed/test_store.py", line 179, in test_multitenancy
Jun 18 22:17:35     store1 = dist.TCPStore(addr, port, 1, True, multi_tenant=True)  # type: ignore[call-arg] # noqa: F841
Jun 18 22:17:35 RuntimeError: Address already in use
Jun 18 22:17:35 
Jun 18 22:17:35 ----------------------------------------------------------------------
Jun 18 22:17:35 Ran 24 tests in 12.301s
Jun 18 22:17:35 
Jun 18 22:17:35 FAILED (errors=1)

2 failures not recognized by patterns:

Job Step Action
CircleCI pytorch_linux_xenial_py3_clang5_asan_test1 Run tests 🔁 rerun
CircleCI pytorch_linux_bionic_cuda10_2_cudnn7_py3_9_gcc7_test2 Run tests 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

jbschlosser
jbschlosser reviewed Jun 16, 2021
View reviewed changes
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, another doc gap filled in :) couple minor comments then good to go

jbschlosser
jbschlosser approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facebook-github-bot
Copy link
Contributor

@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jbschlosser merged this pull request in 1c97c3e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbschlosser jbschlosser jbschlosser approved these changes

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

cla signed Merged module: docs Related to our documentation, both in docs/ and docblocks module: nn Related to torch.nn open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

torch.nn.LSTM does not document reverse weights for bidirectional LSTMs

4 participants

@thomasjpfan @facebook-github-bot @jbschlosser @pytorchbot