add support for constant #60166
add support for constant #60166
Conversation
💊 CI failures summary and remediationsAs of commit 9a744f9 (more details on the Dr. CI page and at hud.pytorch.org/pr/60166): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@pmeier sorry as I have made a mess with commits , so have to delete the previous branch, I`ve updated here again |
There was a problem hiding this comment.
sorry as I have made a mess with commits , so have to delete the previous branch, I`ve updated here again
Happens to the best of us 😉 You accidentally included updates to the ideep submodule in the branch. Here is how you get them out again:
$ cd $PYTORCH/third_party/ideep
$ git checkout f9468ff1a3d601b509ebe2c17d2ed0a58dffacee
$ git commit -am "revert submodule update"
$ git pushIf you run git submodule update after doing a git pull you won't have this problem in the future.
|
For reference, the old PR is #59910. |
|
@pmeier I have tried your steps but i am getting a permission denied while trying to push could you help me figure it out? |
|
You need to perform these steps while on your branch. "Permission denied" most likely means that your trying to push to branch that isn't yours. Probably master. |
|
I have tried these steps on my branch itself but still it shows "Permission Denied" |
|
Ahh sorry, do a |
|
The commit is still there. Is it ok for you if I fix the branch so we can land this PR? |
|
yes absolutely not an issue 😃 |
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
6 participants
Fixes #58739 Add support for constants according to python array API stipulation.