KEMBAR78
DOC Describes parameters/buffers registered as None in load_state_dict by thomasjpfan · Pull Request #60549 · pytorch/pytorch · GitHub
Skip to content

DOC Describes parameters/buffers registered as None in load_state_dict #60549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

DOC Describes parameters/buffers registered as None in load_state_dict #60549

wants to merge 2 commits into from

Conversation

@thomasjpfan
Copy link
Contributor

Related to #8104

@thomasjpfan thomasjpfan added module: nn Related to torch.nn triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jun 23, 2021
@thomasjpfan thomasjpfan requested a review from jbschlosser June 23, 2021 16:22
@thomasjpfan thomasjpfan requested a review from albanD as a code owner June 23, 2021 16:22
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 23, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 687d130 (more details on the Dr. CI page and at hud.pytorch.org/pr/60549):

  • 2/3 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)
  • 1/3 broken upstream at merge base e8690da from Jun 22 until Jun 23

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_macos_10_13_py3_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Jun 23 23:07:31 RuntimeError: test_quantization failed! 
Jun 23 23:07:30 Generated XML report: test-reports/dist-gloo/test_quantization/TEST-quantization.core.test_quantized_op.TestQNNPackOps-20210623230435.xml
Jun 23 23:07:30 Generated XML report: test-reports/dist-gloo/test_quantization/TEST-quantization.fx.test_quantize_fx.TestQuantizeFx-20210623230435.xml
Jun 23 23:07:30 Generated XML report: test-reports/dist-gloo/test_quantization/TEST-quantization.fx.test_quantize_fx.TestQuantizeFxOps-20210623230435.xml
Jun 23 23:07:30 Generated XML report: test-reports/dist-gloo/test_quantization/TEST-quantization.eager.test_quantize_eager_ptq.TestQuantizeONNXExport-20210623230435.xml
Jun 23 23:07:30 Generated XML report: test-reports/dist-gloo/test_quantization/TEST-quantization.core.test_quantized_op.TestQuantizedEmbeddingOps-20210623230435.xml
Jun 23 23:07:31 Traceback (most recent call last):
Jun 23 23:07:31   File "test/run_test.py", line 1313, in <module>
Jun 23 23:07:31     main()
Jun 23 23:07:31   File "test/run_test.py", line 1292, in main
Jun 23 23:07:31     raise RuntimeError(err_message)
Jun 23 23:07:31 RuntimeError: test_quantization failed!
Jun 23 23:07:31 + cleanup
Jun 23 23:07:31 + retcode=1
Jun 23 23:07:31 + set +x


Exited with code exit status 1

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

jbschlosser
jbschlosser reviewed Jun 23, 2021
View reviewed changes
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo but looks good otherwise!

torch/nn/modules/module.py Outdated
Note:
If a parameter or buffer is registered as ``None`` and its corresponding key
exists :attr:`state_dict`, :meth:`load_state_dict` will raise a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: exists -> exists in

@facebook-github-bot
Copy link
Contributor

@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jbschlosser merged this pull request in 6d1b464.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbschlosser jbschlosser jbschlosser approved these changes

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

cla signed Merged module: nn Related to torch.nn open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thomasjpfan @facebook-github-bot @jbschlosser @pytorchbot