Make torch.utils.bencmark numpy free #60564
Closed
+17
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit b44d1ea (more details on the Dr. CI page and at hud.pytorch.org/pr/60564):
1 failure not recognized by patterns:
Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
malfet
force-pushed
the
malfet/make-torch.utils.benchmarks-numpy-free
branch
from
1ef6e73 to
16c8809
Compare
torch.median() for tensors with even number of elements returns lower of two medians, while numpy returns average, which corresponds to `quantile(0.5)`
malfet
force-pushed
the
malfet/make-torch.utils.benchmarks-numpy-free
branch
from
16c8809 to
b44d1ea
Compare
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I think it's ready for review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch core do not depend on numpy, so benchmarks should not depend on it as well