-
Notifications
You must be signed in to change notification settings - Fork 25.7k
fix torch.futures docstring examples
#61029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit f5db4e8 (more details on the Dr. CI page and at hud.pytorch.org/pr/61029): ✅ None of the CI failures appear to be your fault 💚
🚧 2 fixed upstream failures:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
|
@mrshenli -- you OK to review this? |
Codecov Report
@@ Coverage Diff @@
## master #61029 +/- ##
==========================================
- Coverage 80.60% 75.73% -4.88%
==========================================
Files 1879 2062 +183
Lines 202892 209335 +6443
==========================================
- Hits 163543 158534 -5009
- Misses 39349 50801 +11452 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc fixes LGTM. Thanks for fixing!
Did you get a chance to check that the result renders correctly in our doc page?
|
@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Trying to run the doctests for the complete documentation hangs if it reaches the examples of
torch.futures. It turns out to be only syntax errors, which are normally just reported. My guess is thatdoctestprobably doesn't work well for failures within async stuff.Anyway, while debugging this, I fixed the syntax.