KEMBAR78
use make_unique instead of std::unique_ptr in CudaCachingAllocator by cyyever · Pull Request #61272 · pytorch/pytorch · GitHub
Skip to content

use make_unique instead of std::unique_ptr in CudaCachingAllocator #61272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

use make_unique instead of std::unique_ptr in CudaCachingAllocator #61272

wants to merge 2 commits into from

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Jul 6, 2021

No description provided.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 6, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 672177c (more details on the Dr. CI page):

  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_clang5_asan_test2 (1/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jul 06 10:27:02 SUMMARY: UndefinedBehaviorSanit.../jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in 
Jul 06 10:27:02     #9 0x55e5bb3ca8f2 in PyEval_EvalCode /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Python/ceval.c:731
Jul 06 10:27:02     #10 0x55e5bb432cd5 in run_mod /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Python/pythonrun.c:1025
Jul 06 10:27:02     #11 0x55e5bb434d5d in PyRun_StringFlags /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Python/pythonrun.c:949
Jul 06 10:27:02     #12 0x55e5bb434dbb in PyRun_SimpleStringFlags /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Python/pythonrun.c:445
Jul 06 10:27:02     #13 0x55e5bb435926 in run_command /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Modules/main.c:301
Jul 06 10:27:02     #14 0x55e5bb435926 in Py_Main /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Modules/main.c:749
Jul 06 10:27:02     #15 0x55e5bb36f196 in main /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Programs/python.c:69
Jul 06 10:27:02     #16 0x7f331964f83f in __libc_start_main /build/glibc-S7Ft5T/glibc-2.23/csu/../csu/libc-start.c:291
Jul 06 10:27:02     #17 0x55e5bb3ff33d in _start (/opt/conda/bin/python3.6+0x1a733d)
Jul 06 10:27:02 
Jul 06 10:27:02 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in 
Jul 06 10:27:02 + retcode=1
Jul 06 10:27:02 + set -e
Jul 06 10:27:02 + return 1
Jul 06 10:27:02 + [[ pytorch-linux-xenial-py3-clang5-asan-test2 == *-NO_AVX-* ]]
Jul 06 10:27:02 + [[ pytorch-linux-xenial-py3-clang5-asan-test2 == *-NO_AVX2-* ]]
Jul 06 10:27:02 + '[' -n https://github.com/pytorch/pytorch/pull/61272 ']'
Jul 06 10:27:02 + [[ pytorch-linux-xenial-py3-clang5-asan-test2 != *coverage* ]]
Jul 06 10:27:02 ++ mktemp
Jul 06 10:27:02 + DETERMINE_FROM=/tmp/tmp.sFuVGmndbS
Jul 06 10:27:02 + file_diff_from_base /tmp/tmp.sFuVGmndbS

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (2/2)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Jul 06 09:52:59 rm: cannot remove '/var/lib/jenkins/sccache_error.log': No such file or directory 
Jul 06 09:52:58 ++++ extract_trap_cmd
Jul 06 09:52:58 ++++ printf '%s\n' ''
Jul 06 09:52:58 +++ printf '%s\n' cleanup
Jul 06 09:52:58 ++ trap -- '
Jul 06 09:52:58 cleanup' EXIT
Jul 06 09:52:58 ++ [[ pytorch-xla-linux-bionic-py3.6-clang9-build != *pytorch-win-* ]]
Jul 06 09:52:58 ++ which sccache
Jul 06 09:52:58 ++ sccache --stop-server
Jul 06 09:52:59 ++ true
Jul 06 09:52:59 ++ rm /var/lib/jenkins/sccache_error.log
Jul 06 09:52:59 rm: cannot remove '/var/lib/jenkins/sccache_error.log': No such file or directory
Jul 06 09:52:59 ++ true
Jul 06 09:52:59 ++ [[ -n '' ]]
Jul 06 09:52:59 ++ [[ pytorch-xla-linux-bionic-py3.6-clang9-build == *rocm* ]]
Jul 06 09:52:59 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log
Jul 06 09:52:59 ++ SCCACHE_IDLE_TIMEOUT=1200
Jul 06 09:52:59 ++ RUST_LOG=sccache::server=error
Jul 06 09:52:59 ++ sccache --start-server
Jul 06 09:52:59 sccache: Starting the server...
Jul 06 09:52:59 ++ sccache --zero-stats
Jul 06 09:52:59 Compile requests                      0
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

lezcano
lezcano reviewed Jul 6, 2021
View reviewed changes
Copy link
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this PR is on better practices, while reading it I saw two other low hanging fruits within reach.

@cyyever @lezcano
Update c10/cuda/CUDACachingAllocator.cpp
672177c 
Co-authored-by: Lezcano <Lezcano@users.noreply.github.com>
@facebook-github-bot
Copy link
Contributor

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 12, 2021
@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in 00c4897.

@cyyever cyyever deleted the make_unique branch July 12, 2021 15:13
@ngimel ngimel changed the title use make_unique use make_unique instead of std::unique_ptr in CudaCachinAllocator Oct 18, 2021
@ngimel ngimel changed the title use make_unique instead of std::unique_ptr in CudaCachinAllocator use make_unique instead of std::unique_ptr in CudaCachingAllocator Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lezcano lezcano lezcano left review comments

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cyyever @facebook-github-bot @ezyang @lezcano @pytorchbot