[fx] fix subgraph API call_module warning about no owning module #61463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: seems like a small oversight(?), current test fails when warnings are recorded. discovered this when calling `graph.call_module(existing_call_module_node.target)` and it raised a warning Test Plan: `buck test //caffe2/test:fx` Differential Revision: D29637799 fbshipit-source-id: ef7df667bdf355c3830e714083dab2e59f8fd7cb
💊 CI failures summary and remediationsAs of commit deb882d (more details on the Dr. CI page and at hud.pytorch.org/pr/61463): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D29637799 |
ansley
approved these changes
Jul 9, 2021
|
This pull request has been merged in 1f4bba7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: seems like a small oversight(?), current test fails when warnings are recorded. discovered this when calling
graph.call_module(existing_call_module_node.target)and it raised a warningTest Plan:
buck test //caffe2/test:fxDifferential Revision: D29637799