Remove test_out, test_variant_consistency_eager skips for addmv; fixed before
#61579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit dd0c1d4 (more details on the Dr. CI page and at hud.pytorch.org/pr/61579): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
krshrimali
changed the title
addmv; fixed beforeaddmv; fixed before
H-Huang
added
the
triaged
krshrimali
added
the
module: testing
mruberry
reviewed
Jul 15, 2021
| broadcasts_input=broadcasts_input)) | ||
| return tuple(sample_inputs) | ||
|
|
||
| def generator(): |
mruberry
reviewed
Jul 15, 2021
| dtypesIfROCM=floating_types_and(torch.half), | ||
| supports_inplace_autograd=False, | ||
| supports_forward_ad=True, | ||
| skips=( |
There was a problem hiding this comment.
Always awesome to see skips removed
mruberry
approved these changes
Jul 15, 2021
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
test_outskip: it's not needed anymore after it was fixed inaddmv: port to structured kernels, improve error checks #55746. This should also close addmv_() allows resizing the tensor it operates on and produces wrong results #55589.test_variant_consistency_eagerskip, it was added by mistake in [testing] addbroadcasts_inputand verifies the behaviour for inplace_variant. #55771.sample_inputs_addmvfunction, the updated function should now be cleaner and easy to read.cc: @mruberry