KEMBAR78
Add `complex64` dtype for OpInfo Reference testing by krshrimali · Pull Request #61627 · pytorch/pytorch · GitHub
Skip to content

Conversation

@krshrimali
Copy link
Contributor

@krshrimali krshrimali commented Jul 14, 2021

This PR adds complex64 dtype testing, following conversation from: pytorch/xla#3019 (comment). Original PR that added OpInfo reference testing: #59369.

cc: @mruberry @kshitij12345

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 14, 2021

💊 CI failures summary and remediations

As of commit d970b00 (more details on the Dr. CI page and at hud.pytorch.org/pr/61627):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@krshrimali krshrimali added the module: testing Issues related to the torch.testing module (not tests) label Jul 14, 2021
Copy link
Collaborator

@kshitij12345 kshitij12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's wait for the green signal from CI

Thanks @krshrimali

Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@facebook-github-bot
Copy link
Contributor

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mruberry merged this pull request in 4ff121f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged module: testing Issues related to the torch.testing module (not tests) open source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants