KEMBAR78
Fix grammatical errors on the PyTorch Contribution Guide by ndkshr · Pull Request #61818 · pytorch/pytorch · GitHub
Skip to content

Fix grammatical errors on the PyTorch Contribution Guide #61818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix grammatical errors on the PyTorch Contribution Guide #61818

wants to merge 1 commit into from

Conversation

@ndkshr
Copy link
Contributor

@ndkshr ndkshr commented Jul 18, 2021

What does the PR do?

  • Fix grammatical errors on the PyTorch Contribution Guide page.

Changes [Screenshots]

Note:

  1. The changes are highlighted in each screenshot.
  2. Could not load CSS while testing locally, hope that is not an issue as all the changes are made on the content.

Change1

Change2

Change3

Change4

Change5

Change6

Change7

Change8

@facebook-github-bot
Copy link
Contributor

Hi @ndkshr!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 18, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit c8a242a (more details on the Dr. CI page and at hud.pytorch.org/pr/61818):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

mrshenli
mrshenli approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@facebook-github-bot
Copy link
Contributor

@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mrshenli merged this pull request in 0a6d882.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrshenli mrshenli mrshenli approved these changes

Assignees

No one assigned

Labels

cla signed Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ndkshr @facebook-github-bot @mrshenli @pytorchbot