Split zeta_kernel out of BinaryMiscOpsKernel.cu #62261
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryMiscOpsKernel.cu takes 4 m 30 s to compile on my machine. Moving the zeta kernel into it's own file takes 3 m 30 s, and reduces BinaryMiscOpsKernel.cu compile time to 1 m.
peterbell10
added
module: cuda
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit ef25eb3 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
ejguan
added
the
triaged
ngimel
approved these changes
Jul 28, 2021
|
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BinaryMiscOpsKernel.cutakes 4 m 30 s to compile on my machine, which is the second slowest afterPowKernel.cu. Moving the zeta kernel into it's own file takes 3 m 30 s, and reducesBinaryMiscOpsKernel.cucompile time to 1 m.