KEMBAR78
Add tutorial link by awgu · Pull Request #62785 · pytorch/pytorch · GitHub
Skip to content

Add tutorial link #62785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add tutorial link #62785

wants to merge 1 commit into from

Conversation

@awgu
Copy link
Collaborator

@awgu awgu commented Aug 5, 2021

Addresses: #62605 (comment)

Test Plan:
I checked the render, and the link redirects as desired.

@facebook-github-bot facebook-github-bot added oncall: distributed Add this issue/PR to distributed oncall triage queue cla signed labels Aug 5, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 5, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 85535dc (more details on the Dr. CI page):

  • 2/3 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)
  • 1/3 broken upstream at merge base 658540f on Aug 04 from 3:35pm to 6:37pm

1 failure not recognized by patterns:

Job Step Action
GitHub Actions Lint / quick-checks Ensure no trailing spaces 🔁 rerun

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@awgu awgu requested a review from mrshenli August 5, 2021 00:24
mrshenli
mrshenli approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/source/distributed.algorithms.join.rst
.. autoclass:: torch.distributed.algorithms.JoinHook
:members:

.. _Distributed Training with Uneven Inputs Using the Join Context Manager: https://pytorch.org/tutorials/advanced/generic_join.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this won't be rendered and will only be used by the reference on line 9 as a hyperlink?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup.

@facebook-github-bot
Copy link
Contributor

@andwgu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@andwgu merged this pull request in 8aa12cb.

@awgu awgu deleted the join_tutorial branch February 3, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrshenli mrshenli mrshenli approved these changes

Assignees

No one assigned

Labels

cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@awgu @facebook-github-bot @mrshenli