KEMBAR78
Advertise USE_PRECOMPILED_HEADERS in CONTRIBUTING.md by peterbell10 · Pull Request #62827 · pytorch/pytorch · GitHub
Skip to content

Advertise USE_PRECOMPILED_HEADERS in CONTRIBUTING.md #62827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Advertise USE_PRECOMPILED_HEADERS in CONTRIBUTING.md #62827

wants to merge 1 commit into from

Conversation

@peterbell10
Copy link
Collaborator

This option was added in #61940 and fits with this section's theme of improving build times.

I've also changed it to a cmake_dependent_option instead of FATAL_ERRORing for older CMake versions.

@peterbell10 peterbell10 requested a review from malfet August 5, 2021 16:50
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 5, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit a1d91fd (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_xenial_cuda11_1_cudnn8_py3_gcc7_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Aug 05 21:14:00 unknown file: Failure 
Aug 05 21:14:00 frame #9: build/bin/test_api() [0xbdb39a]
Aug 05 21:14:00 frame #10: build/bin/test_api() [0xbdbbed]
Aug 05 21:14:00 frame #11: testing::internal::UnitTestImpl::RunAllTests() + 0xe27 (0xbe47b7 in build/bin/test_api)
Aug 05 21:14:00 frame #12: testing::UnitTest::Run() + 0x8f (0xbe4b6f in build/bin/test_api)
Aug 05 21:14:00 frame #13: main + 0xc8 (0x586cb8 in build/bin/test_api)
Aug 05 21:14:00 frame #14: __libc_start_main + 0xf0 (0x7f1e2c8ff840 in /lib/x86_64-linux-gnu/libc.so.6)
Aug 05 21:14:00 frame #15: _start + 0x29 (0x5c7b29 in build/bin/test_api)
Aug 05 21:14:00 " thrown in the test body.
Aug 05 21:14:00 [  FAILED  ] IMethodTest.CallMethod (4 ms)
Aug 05 21:14:00 [ RUN      ] IMethodTest.GetArgumentNames
Aug 05 21:14:00 unknown file: Failure
Aug 05 21:14:00 C++ exception with description "open file failed, file path: torch/csrc/deploy/example/generated/simple_jit
Aug 05 21:14:00 Exception raised from RAIIFile at /var/lib/jenkins/workspace/caffe2/serialize/file_adapter.cc:13 (most recent call first):
Aug 05 21:14:00 frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x6b (0x7f1e2d0154ab in /var/lib/jenkins/workspace/build/lib/libc10.so)
Aug 05 21:14:00 frame #1: c10::detail::torchCheckFail(char const*, char const*, unsigned int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) + 0xce (0x7f1e2d010c6e in /var/lib/jenkins/workspace/build/lib/libc10.so)
Aug 05 21:14:00 frame #2: caffe2::serialize::FileAdapter::RAIIFile::RAIIFile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) + 0xdc (0x7f1e4921903c in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so)
Aug 05 21:14:00 frame #3: caffe2::serialize::FileAdapter::FileAdapter(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) + 0x41 (0x7f1e492196c1 in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so)
Aug 05 21:14:00 frame #4: torch::jit::load(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, c10::optional<c10::Device>, std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >&) + 0x40 (0x7f1e4a874370 in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so)
Aug 05 21:14:00 frame #5: torch::jit::load(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, c10::optional<c10::Device>) + 0x6f (0x7f1e4a8744ff in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so)
Aug 05 21:14:00 frame #6: IMethodTest_GetArgumentNames_Test::TestBody() + 0x7e (0xb9f5be in build/bin/test_api)
Aug 05 21:14:00 frame #7: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 0x4a (0xbebafa in build/bin/test_api)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@peterbell10
Advertise USE_PRECOMPILED_HEADERS in CONTRIBUTING.md
a1d91fd 
This option was added in pytorch#61940 and fits with this section's theme of improving
build times.

I've also changed it to a `cmake_dependent_option` instead of `FATAL_ERROR`ing
for older CMake versions.
@H-Huang H-Huang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 5, 2021
@facebook-github-bot
Copy link
Contributor

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@malfet merged this pull request in f70b9ee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peterbell10 @facebook-github-bot @malfet @H-Huang