KEMBAR78
Add OpInfo for `nn.functional.cosine_similarity` by krshrimali · Pull Request #62959 · pytorch/pytorch · GitHub
Skip to content

Add OpInfo for nn.functional.cosine_similarity #62959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Add OpInfo for nn.functional.cosine_similarity #62959

wants to merge 6 commits into from

Conversation

@krshrimali
Copy link
Contributor

@krshrimali krshrimali commented Aug 9, 2021 •
edited
Loading

Please see pytorch/functorch#78 and #54261.

Notes:

  • Some redundant tests from test_nn.py have been removed. I'm unsure about precision checks if they can be removed as well.
  • Broadcasting is also checked in the OpInfo for cosine_similarity.

cc: @mruberry @zou3519 @Chillee

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 9, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 9a246f2 (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

1 failure not recognized by patterns:

Job Step Action
CircleCI pytorch_linux_xenial_cuda11_1_cudnn8_py3_gcc7_test2 Set Up CI Environment After attach_workspace 🔁 rerun

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@krshrimali krshrimali added the module: testing Issues related to the torch.testing module (not tests) label Aug 9, 2021
@krshrimali krshrimali requested a review from zou3519 August 9, 2021 09:12
@gchanan gchanan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 9, 2021
zou3519
zou3519 reviewed Aug 10, 2021
View reviewed changes
zou3519
zou3519 reviewed Aug 10, 2021
View reviewed changes
@krshrimali krshrimali requested a review from zou3519 August 11, 2021 03:51
@zou3519 zou3519 mentioned this pull request Aug 24, 2021
Closed
23 tasks
@facebook-github-bot
Copy link
Contributor

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zou3519 zou3519 mentioned this pull request Aug 26, 2021
Closed
@zou3519
Copy link
Contributor

zou3519 commented Aug 31, 2021

I'm still working on merging this!

@facebook-github-bot
Copy link
Contributor

@zou3519 merged this pull request in ca8dd29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

cla signed Merged module: testing Issues related to the torch.testing module (not tests) open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@krshrimali @facebook-github-bot @zou3519 @gchanan @pytorchbot