clarify the documentation of torch.meshgrid
#62977
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 76077c4 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
dagitses
force-pushed
the
dagitses/meshgrid-doc
branch
4 times, most recently
from
45034ab to
fdda4da
Compare
|
@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
dagitses
force-pushed
the
dagitses/meshgrid-doc
branch
from
fdda4da to
d1ec83b
Compare
dagitses
changed the base branch from
master
to
dagitses/#62719/meshgrid-opinfo
mruberry
reviewed
Aug 11, 2021
mruberry
reviewed
Aug 11, 2021
dagitses
force-pushed
the
dagitses/#62719/meshgrid-opinfo
branch
from
4ff55ce to
3075f39
Compare
mruberry
reviewed
Aug 11, 2021
mruberry
reviewed
Aug 11, 2021
mruberry
reviewed
Aug 11, 2021
mruberry
reviewed
Aug 11, 2021
mruberry
reviewed
Aug 11, 2021
mruberry
reviewed
Aug 11, 2021
mruberry
reviewed
Aug 11, 2021
dagitses
force-pushed
the
dagitses/#62719/meshgrid-opinfo
branch
from
3075f39 to
2099130
Compare
dagitses
force-pushed
the
dagitses/meshgrid-doc
branch
6 times, most recently
from
b9a9020 to
c8d30d3
Compare
dagitses
force-pushed
the
dagitses/#62719/meshgrid-opinfo
branch
from
2099130 to
95bbdc6
Compare
dagitses
force-pushed
the
dagitses/meshgrid-doc
branch
from
c8d30d3 to
b433db8
Compare
mruberry
removed request for
H-Huang,
cbalioglu,
driazati,
janeyx99,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
seemethere,
wayi1 and
zhaojuanmao
dagitses
changed the base branch from
dagitses/#62719/meshgrid-opinfo
to
master
fixed. i just needed to change the base branch since I regrettably didn't use ghstack with this set of changes. |
mruberry
reviewed
Aug 17, 2021
|
@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mruberry
approved these changes
Aug 17, 2021
dagitses
force-pushed
the
dagitses/meshgrid-doc
branch
from
2ba034a to
1afa817
Compare
|
@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
test failures look unrelated to my change. landing. |
dagitses
force-pushed
the
dagitses/meshgrid-doc
branch
from
1afa817 to
d7195ec
Compare
Also warn about the behavior differences from `numpy.meshgrid`.
dagitses
force-pushed
the
dagitses/meshgrid-doc
branch
from
d7195ec to
76077c4
Compare
|
@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also warn about the behavior differences from
numpy.meshgrid.