KEMBAR78
Update full backward hook doc with not-same-object note by albanD · Pull Request #63245 · pytorch/pytorch · GitHub
Skip to content

Update full backward hook doc with not-same-object note #63245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Update full backward hook doc with not-same-object note #63245

wants to merge 3 commits into from

Conversation

@albanD
Copy link
Collaborator

@albanD albanD commented Aug 13, 2021

Fixes #61446

@albanD albanD requested a review from mruberry August 13, 2021 18:31
@albanD albanD requested a review from jbschlosser as a code owner August 13, 2021 18:31
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 13, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit a706468 (more details on the Dr. CI page):

  • 3/3 failures possibly* introduced in this PR
    • 1/3 non-scanned failure(s)

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (1/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result. 
CONFLICT (add/add): Merge conflict in .circleci/scripts/binary_ios_test.sh
Auto-merging .circleci/scripts/binary_ios_test.sh
CONFLICT (add/add): Merge conflict in .circleci/scripts/binary_ios_build.sh
Auto-merging .circleci/scripts/binary_ios_build.sh
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/windows_build_definitions.py
Auto-merging .circleci/cimodel/data/windows_build_definitions.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/simple/nightly_ios.py
Auto-merging .circleci/cimodel/data/simple/nightly_ios.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (2/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result. 
CONFLICT (add/add): Merge conflict in .circleci/scripts/binary_ios_test.sh
Auto-merging .circleci/scripts/binary_ios_test.sh
CONFLICT (add/add): Merge conflict in .circleci/scripts/binary_ios_build.sh
Auto-merging .circleci/scripts/binary_ios_build.sh
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/windows_build_definitions.py
Auto-merging .circleci/cimodel/data/windows_build_definitions.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/simple/nightly_ios.py
Auto-merging .circleci/cimodel/data/simple/nightly_ios.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

mruberry
mruberry reviewed Aug 16, 2021
View reviewed changes
mruberry
mruberry reviewed Aug 16, 2021
View reviewed changes
torch/nn/modules/module.py Outdated
arguments.
Note that this hook need to apply a Function to the inputs and outputs of the Module
during the forward pass. This means that Tensors passed as argument to the Module and
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically words like "Tensors" and "Module" aren't capitalized

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho really? I always capitalize them when they refer to the actual PyTorch objects and not when they refer to general tensor/module.
Should I update it here?

Note that two lines above, there is a capitalized Tensor haha

mruberry
mruberry reviewed Aug 16, 2021
View reviewed changes
mruberry
mruberry reviewed Aug 16, 2021
View reviewed changes
@mruberry mruberry self-requested a review August 16, 2021 08:49
mruberry
mruberry approved these changes Aug 16, 2021
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @albanD! Overall looks good. I made a few wording suggestions for your review.

@albanD albanD requested a review from mruberry August 16, 2021 14:38
@albanD
Copy link
Collaborator Author

albanD commented Aug 16, 2021

@mruberry could you take a second look please? I did a full rewrite following your advice.

mruberry
mruberry approved these changes Aug 16, 2021
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facebook-github-bot
Copy link
Contributor

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@albanD merged this pull request in 2d5b19f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

Assignees

No one assigned

Labels

cla signed hackathon Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No-op full backward hooks modify the input

3 participants

@albanD @facebook-github-bot @mruberry