TST Adds inplace checks to module_info #63739
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
added
module: nn
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 18244c0 (more details on the Dr. CI page):
1 failure not recognized by patterns:
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
Codecov Report
@@ Coverage Diff @@
## master #63739 +/- ##
==========================================
+ Coverage 66.60% 66.67% +0.07%
==========================================
Files 705 708 +3
Lines 92215 92412 +197
==========================================
+ Hits 61420 61619 +199
+ Misses 30795 30793 -2 |
jbschlosser
reviewed
Aug 31, 2021
jbschlosser
reviewed
Sep 2, 2021
test/test_modules.py
Outdated
| @modules(module_db) | ||
| def test_pickle(self, device, dtype, module_info): | ||
| # Test that module can be pickled and unpickled. | ||
| def test_check_inplace(self, device, dtype, module_info): |
There was a problem hiding this comment.
@thomasjpfan Hm, looks like a merge conflict happened or something - we've now got 2 definitions for test_check_inplace that the linter is complaining about
|
@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@jbschlosser merged this pull request in 43c0f03. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #61935
This PR adds inplace checks to
test_modules. This version checks the constructor forinplaceand performs the check automatically.cc @albanD @mruberry @jbschlosser @walterddr