To add Adamax algorithm to documentation #63903
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 6aada3f (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
iramazanli
force-pushed
the
adamax_algorithm_doc
branch
3 times, most recently
from
7d4f467 to
8391319
Compare
Codecov Report
@@ Coverage Diff @@
## master #63903 +/- ##
=======================================
Coverage 66.81% 66.82%
=======================================
Files 695 698 +3
Lines 90845 90881 +36
=======================================
+ Hits 60701 60733 +32
- Misses 30144 30148 +4 |
iramazanli
force-pushed
the
adamax_algorithm_doc
branch
6 times, most recently
from
23ac602 to
f485036
Compare
iramazanli
force-pushed
the
adamax_algorithm_doc
branch
from
f485036 to
088903a
Compare
albanD
reviewed
Sep 7, 2021
torch/optim/adamax.py
Outdated
There was a problem hiding this comment.
The code actually adds an epsilon to the absolute value no?
iramazanli
force-pushed
the
adamax_algorithm_doc
branch
from
088903a to
3f765ae
Compare
|
@iramazanli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
iramazanli
force-pushed
the
adamax_algorithm_doc
branch
from
3f765ae to
6aada3f
Compare
|
@iramazanli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@iramazanli merged this pull request in 39ce801. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been discussed before that adding description of Optimization algorithms to PyTorch Core documentation may result in a nice Optimization research tutorial. In the following tracking issue we mentioned about all the necessary algorithms and links to the originally published paper #63236.
In this PR we are adding description of Adamax Algorithm to the documentation. For more details, we refer to the paper https://arxiv.org/abs/1412.6980