Fixes failure in test_dataloader.py that occurs on jetson boards #64757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CUDA IPC is not supported for jetsons
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit e51b72b (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
ptrblck
reviewed
Sep 9, 2021
test/test_dataloader.py
Outdated
| # CUDA OOM error on Windows. | ||
| TEST_CUDA = torch.cuda.is_available() | ||
|
|
||
| dev_name = torch.cuda.get_device_name(torch.cuda.current_device()).lower() |
There was a problem hiding this comment.
Would this crash, if no GPU is available, or what is cuda.get_device_name returning in this case?
There was a problem hiding this comment.
yes it would crash, i added a guard against this.
ptrblck
reviewed
Sep 9, 2021
| for ctx in supported_multiprocessing_contexts: | ||
| # windows doesn't support sharing cuda tensor; ROCm does not yet fully support IPC | ||
| if ctx in ['spawn', 'forkserver'] and TEST_CUDA and not IS_WINDOWS: | ||
| if ctx in ['spawn', 'forkserver'] and TEST_CUDA and not IS_WINDOWS and not IS_JETSON: |
There was a problem hiding this comment.
Maybe update the comment, too.
Codecov Report
@@ Coverage Diff @@
## master #64757 +/- ##
==========================================
- Coverage 66.65% 66.65% -0.01%
==========================================
Files 710 710
Lines 92418 92418
==========================================
- Hits 61601 61598 -3
- Misses 30817 30820 +3 |
ngimel
added
the
triaged
ejguan
approved these changes
Sep 13, 2021
|
@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUDA IPC is not supported for jetsons