KEMBAR78
Remove 9.2 related macros for CONSTEXPR by janeyx99 · Pull Request #65066 · pytorch/pytorch · GitHub
Skip to content

Remove 9.2 related macros for CONSTEXPR #65066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Remove 9.2 related macros for CONSTEXPR #65066

wants to merge 5 commits into from

Conversation

@janeyx99
Copy link
Contributor

Removes C10_HOST_CONSTEXPR_EXCEPT_CUDA92 references in the code

@pytorch-probot pytorch-probot bot assigned pytorchbot and unassigned pytorchbot Sep 15, 2021
@pytorch-probot
Copy link

pytorch-probot bot commented Sep 15, 2021 •
edited
Loading

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/janeyx99/pytorch/blob/e06c3646c6775a3df9264b3a19369f1e16f52b29/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default,ciflow/win

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-bionic-py3.6-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/xla ✅ triggered
linux-bionic-py3.8-gcc9-coverage ciflow/all, ciflow/coverage, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/win ✅ triggered
win-vs2019-cuda10.2-py3 ciflow/all, ciflow/cuda, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/win ✅ triggered
Skipped Workflows
libtorch-linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
parallelnative-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
paralleltbb-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
puretorch-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands: 
# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 15, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit e06c364 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build win-vs2019-cuda10.2-py3 / test (default, 1, 2, windows.8xlarge.nvidia.gpu) (1/1)

Step: "Run test scripts" (full log | diagnosis details | 🔁 rerun)

2021-09-17T18:38:38.5312708Z RuntimeError: test_ops failed! 
2021-09-17T18:38:28.5247145Z Generated XML report: test-reports\python-unittest\test_ops\TEST-TestGradientsCUDA-20210917175024.xml
2021-09-17T18:38:28.5248668Z Generated XML report: test-reports\python-unittest\test_ops\TEST-TestJitCPU-20210917175024.xml
2021-09-17T18:38:28.5250030Z Generated XML report: test-reports\python-unittest\test_ops\TEST-TestJitCUDA-20210917175024.xml
2021-09-17T18:38:28.5251526Z Generated XML report: test-reports\python-unittest\test_ops\TEST-TestMathBitsCPU-20210917175024.xml
2021-09-17T18:38:28.5253097Z Generated XML report: test-reports\python-unittest\test_ops\TEST-TestMathBitsCUDA-20210917175024.xml
2021-09-17T18:38:38.5309380Z Traceback (most recent call last):
2021-09-17T18:38:38.5310279Z   File "run_test.py", line 1027, in <module>
2021-09-17T18:38:38.5310860Z     main()
2021-09-17T18:38:38.5311329Z   File "run_test.py", line 1005, in main
2021-09-17T18:38:38.5311898Z     raise RuntimeError(err_message)
2021-09-17T18:38:38.5312708Z RuntimeError: test_ops failed!
2021-09-17T18:38:38.8911330Z 
2021-09-17T18:38:38.8912764Z (base) C:\actions-runner\_work\pytorch\pytorch\pytorch-1245913344\test>if ERRORLEVEL 1 exit /b 1 
2021-09-17T18:38:38.8954356Z + cleanup
2021-09-17T18:38:38.8955112Z + retcode=1
2021-09-17T18:38:38.8955777Z + set +x
2021-09-17T18:38:38.8996101Z ##[error]Process completed with exit code 1.
2021-09-17T18:38:38.9195237Z ##[group]Run # -ir => recursive include all files in pattern
2021-09-17T18:38:38.9196147Z �[36;1m# -ir => recursive include all files in pattern�[0m
2021-09-17T18:38:38.9196852Z �[36;1m7z a "test-reports-$Env:FILE_SUFFIX.zip" -ir'!test\*.xml'�[0m
2021-09-17T18:38:38.9227547Z shell: C:\Windows\System32\WindowsPowerShell\v1.0\powershell.EXE -command ". '{0}'"
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@janeyx99 janeyx99 assigned pytorchbot and unassigned pytorchbot Sep 15, 2021
@janeyx99 janeyx99 requested a review from a team September 15, 2021 16:23
driazati
driazati approved these changes Sep 15, 2021
View reviewed changes
c10/macros/Macros.h Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you file an issue with the whole message then say here that this can be deleted when that’s fixed

@pytorch-probot pytorch-probot bot assigned pytorchbot and unassigned pytorchbot Sep 15, 2021
@janeyx99 janeyx99 mentioned this pull request Sep 15, 2021
Closed
@pytorch-probot pytorch-probot bot assigned pytorchbot and unassigned pytorchbot Sep 15, 2021
@pytorch-probot pytorch-probot bot assigned pytorchbot and unassigned pytorchbot Sep 15, 2021
@pytorch-probot pytorch-probot bot assigned pytorchbot and unassigned pytorchbot Sep 16, 2021
@codecov
Copy link

codecov bot commented Sep 17, 2021 •
edited
Loading

Codecov Report

Merging #65066 (e06c364) into master (8800a8b) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #65066      +/-   ##
==========================================
- Coverage   66.37%   66.12%   -0.25%     
==========================================
  Files         727      734       +7     
  Lines       93571    94786    +1215     
==========================================
+ Hits        62109    62679     +570     
- Misses      31462    32107     +645

@janeyx99
Copy link
Contributor Author

@pytorchbot ciflow rerun -l ciflow/win

@pytorch-probot pytorch-probot bot assigned pytorchbot and unassigned pytorchbot Sep 17, 2021
@facebook-github-bot
Copy link
Contributor

@janeyx99 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@janeyx99 merged this pull request in 6707dfe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@driazati driazati driazati approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@janeyx99 @facebook-github-bot @driazati @pytorchbot