KEMBAR78
Add shape function for movedim op by vivekkhandelwal1 · Pull Request #91696 · pytorch/pytorch · GitHub
Skip to content

Add shape function for movedim op #91696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add shape function for movedim op #91696

wants to merge 1 commit into from

Conversation

@vivekkhandelwal1
Copy link
Contributor

@vivekkhandelwal1 vivekkhandelwal1 commented Jan 4, 2023 •
edited
Loading

Signed-Off By: Vivek Khandelwalvivek@nod-labs.com

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 4, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91696

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 339d04d:

FLAKY - The following jobs failed but were likely due to flakiness present on master:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Jan 4, 2023
@vivekkhandelwal1
Copy link
Contributor Author

@eellison @Gamrix Could you please review this PR?

@vivekkhandelwal1 vivekkhandelwal1 mentioned this pull request Jan 4, 2023
Merged
@zou3519 zou3519 requested a review from davidberard98 January 4, 2023 15:22
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 4, 2023
@Gamrix
Copy link
Contributor

Gamrix commented Jan 5, 2023

Sorry, I no longer work on Pytorch at Meta

@vivekkhandelwal1
Copy link
Contributor Author

Hi, can I get this PR merged? All the checks have passed.

davidberard98
davidberard98 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@davidberard98 davidberard98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@davidberard98
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 5, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@vivekkhandelwal1
Add shape function for movedim op
339d04d 
Signed-Off By: Vivek Khandelwal<vivek@nod-labs.com>
davidberard98
davidberard98 approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@davidberard98 davidberard98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good!

@davidberard98
Copy link
Contributor

@pytorchbot merge -f "the rocm timeout is also observed in the base commit"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@vivekkhandelwal1 vivekkhandelwal1 deleted the movedim-shape branch January 9, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@davidberard98 davidberard98 davidberard98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: jit release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vivekkhandelwal1 @Gamrix @davidberard98 @pytorchmergebot @zou3519 @pytorchbot