KEMBAR78
Fix cache contention for multiple processes by Valentine233 · Pull Request #1400 · pytorch/torchdynamo · GitHub
Skip to content
This repository was archived by the owner on Aug 1, 2025. It is now read-only.

Conversation

@Valentine233
Copy link
Contributor

@Valentine233 Valentine233 commented Sep 28, 2022

Fix cache contention for multiple processes

#1347

@Valentine233 Valentine233 requested review from jgong5 and voznesenskym and removed request for jgong5 and voznesenskym September 28, 2022 07:04
@Valentine233
Copy link
Contributor Author

I am wondering how to run workflows again. Could sb help, pls?

@Chillee
Copy link
Contributor

Chillee commented Sep 28, 2022

First time contributor needs somebody to manually approve.

@voznesenskym
Copy link
Contributor

Edited summary, hope you don't mind.

@voznesenskym
Copy link
Contributor

ModuleNotFoundError: No module named 'filelock'

Please make sure that you add this as a dep, it is failing every CI job atm.

@voznesenskym
Copy link
Contributor

LGTM, will stamp when CI passes.

@jgong5
Copy link

jgong5 commented Sep 28, 2022

@Valentine233 Can you add UT to cover the fix?

@Valentine233 Valentine233 requested review from jgong5 and removed request for voznesenskym September 29, 2022 02:27
@Valentine233 Valentine233 force-pushed the multi-processes-cache branch from 43da76e to 732d022 Compare October 8, 2022 02:02
@Valentine233 Valentine233 requested a review from jgong5 October 8, 2022 02:04
@jgong5 jgong5 requested a review from voznesenskym October 8, 2022 04:58
@Valentine233 Valentine233 requested a review from jgong5 October 8, 2022 09:20
Copy link

@jgong5 jgong5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file an issue for the test to cover multiple instance inference scenario.

@jgong5 jgong5 requested a review from jansel October 8, 2022 09:33
@Valentine233 Valentine233 requested review from jansel and jgong5 October 10, 2022 02:21
@Valentine233 Valentine233 merged commit d81cea4 into pytorch:main Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants