This repository was archived by the owner on Aug 1, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Fix cache contention for multiple processes #1400
Merged
Valentine233
merged 9 commits into
pytorch:main
from
Valentine233:multi-processes-cache
Oct 10, 2022
Merged
Fix cache contention for multiple processes #1400
Valentine233
merged 9 commits into
pytorch:main
from
Valentine233:multi-processes-cache
Oct 10, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am wondering how to run workflows again. Could sb help, pls? |
|
First time contributor needs somebody to manually approve. |
|
Edited summary, hope you don't mind. |
Please make sure that you add this as a dep, it is failing every CI job atm. |
|
LGTM, will stamp when CI passes. |
jgong5
suggested changes
Sep 28, 2022
|
@Valentine233 Can you add UT to cover the fix? |
52e4798 to
43da76e
Compare
jgong5
reviewed
Sep 29, 2022
jansel
suggested changes
Sep 29, 2022
43da76e to
732d022
Compare
jgong5
reviewed
Oct 8, 2022
jgong5
approved these changes
Oct 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please file an issue for the test to cover multiple instance inference scenario.
Signed-off-by: Valentine233 <494543506@qq.com>
jansel
reviewed
Oct 9, 2022
jansel
approved these changes
Oct 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cache contention for multiple processes
#1347