KEMBAR78
Remove ReturnListener in RpcClient#close() by JHahnHRO · Pull Request #1169 · rabbitmq/rabbitmq-java-client · GitHub
Skip to content

Remove ReturnListener in RpcClient#close() #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2023
Merged

Remove ReturnListener in RpcClient#close() #1169

merged 1 commit into from
Nov 25, 2023

Conversation

@JHahnHRO
Copy link
Contributor

Proposed Changes

Remove the ReturnListener in RpcClient#close() that is added in the constructor.

Types of Changes

  • Bugfix (non-breaking change which fixes issue Memory leak in RpcClient #1168)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

None.

@pivotal-cla
Copy link

@JHahnHRO Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@JHahnHRO
Copy link
Contributor Author

@pivotal-cla This is an Obvious Fix

@pivotal-cla
Copy link

@JHahnHRO This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@michaelklishin michaelklishin merged commit 00ef564 into rabbitmq:main Nov 25, 2023
@michaelklishin michaelklishin added this to the 5.21.0 milestone Nov 25, 2023
@michaelklishin
Copy link
Contributor

Backported to 5.x. Thank you, @JHahnHRO.

@acogoluegnes acogoluegnes changed the title cleanup ReturnListener in close() Remove ReturnListener in RpcClient#close() Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.21.0

Development

Successfully merging this pull request may close these issues.

3 participants

@JHahnHRO @pivotal-cla @michaelklishin