[2.2-stable] Fix compatibility issues with Ruby 3.4.0dev #2248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gem was made a default gems, so it should be added to the gemspec, but most gems out there decided to just use `pack/unpack` to not add a dependency, that's the approach I used there.
casperisfine
force-pushed
the
2-2-stable-ruby-3.4-compat
branch
from
147aecd to
1d5c992
Compare
jeremyevans
approved these changes
Sep 9, 2024
|
@casperisfine would you like me to cut a release from this or are there additional compatibility issues you'd like to sort out first? |
|
I'm not aware of any more issues. A release would be much appreciated, but we can also wait a bit see if there is any more changes in 3.4, I just fear we might forget. |
|
Okay, I will put a note in my calendar for Thursday next week to cut a release. Let me know if anything else comes up before then :) |
|
I have released v2.2.10 with this (and only this) change. Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know
2.2is marked a security patches only, but given3.xcontains breaking changes, and a large part of the community still haven't been able to upgrade, I think it would be sensible to also consider simple compatibility patches, to make it work on Ruby 3.4.The two issues I found where:
base64warnings, I went the same way as 696ed9e, usingpack/unpack.uriwarnings, just applied a simple fix.NB: Test suite is failing on ruby-head because webrick needs an update: ruby/webrick#144
cc @tenderlove @jeremyevans