KEMBAR78
Polish README by simonbasle · Pull Request #3007 · reactor/reactor-core · GitHub
Skip to content

Polish README #3007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2022
Merged

Polish README #3007

merged 2 commits into from
Apr 20, 2022

Conversation

@simonbasle
Copy link
Contributor

@simonbasle
Remove outdated link to bintray
4fb0340
@simonbasle
Force white background on README marble diagrams
92f94cc 
This allows better readability of the marble diagrams with a dark
background, which is useful since the README is often view on GitHub
(which offers a dark mode).

The canonical usage of the marble diagrams is the reference guide, which
has a white background style, so the SVG is left untouched.

Fixes #3004.
@simonbasle simonbasle requested a review from a team as a code owner April 8, 2022 15:57
@simonbasle simonbasle added this to the 3.5.0-M2 milestone Apr 8, 2022
@simonbasle simonbasle added the type/documentation A documentation update label Apr 8, 2022
@simonbasle simonbasle self-assigned this Apr 8, 2022
@simonbasle simonbasle requested a review from a team April 8, 2022 15:57
@simonbasle simonbasle merged commit b315de6 into main Apr 20, 2022
@simonbasle simonbasle deleted the readmePolish branch April 20, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@simonbasle simonbasle

Labels

type/documentation A documentation update

Projects

None yet

Milestone

3.5.0-M2

Development

Successfully merging this pull request may close these issues.

It's hard to see images in README.md when github dark mode

1 participant

@simonbasle