KEMBAR78
Introduce new module reactor-core-micrometer by simonbasle · Pull Request #3015 · reactor/reactor-core · GitHub
Skip to content

Introduce new module reactor-core-micrometer #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 20, 2022
Merged

Introduce new module reactor-core-micrometer #3015

merged 11 commits into from
Apr 20, 2022

Conversation

@simonbasle
Copy link
Contributor

groupId: io.projectreactor.observability

  • reactor-metrics-micrometer explicitly depends on micrometer-core
  • it provides an implementation of SignalListener for metrics
  • it supersedes FluxMetrics and Metrics/MicrometerConfiguration in core
  • the above are now deprecated
  • Metrics.isInstrumentationAvailable() will answer false if the new
    module is detected on the classpath

TODO: more tests on the MetricsListener

@simonbasle simonbasle mentioned this pull request Apr 14, 2022
Merged
@simonbasle simonbasle added type/enhancement A general enhancement warn/deprecation This issue/PR introduces deprecations labels Apr 14, 2022
@simonbasle simonbasle added this to the 3.5.0-M2 milestone Apr 14, 2022
Base automatically changed from observabilityOperator to main April 19, 2022 09:24
@simonbasle
Introduce new module reactor-metrics-micrometer
906593d 
groupId: io.projectreactor.observability

 - reactor-metrics-micrometer explicitly depends on micrometer-core
 - it provides an implementation of SignalListener for metrics
 - it supersedes FluxMetrics and Metrics/MicrometerConfiguration in core
 - the above are now deprecated
 - Metrics.isInstrumentationAvailable() will answer false if the new
 module is detected on the classpath

TODO: more tests on the MetricsListener
@simonbasle
copy scheduler decorator, expose metrics(registry,clock) factory
988e5a4
@simonbasle
revert class visibility wrongly set to public
e29e20d
@simonbasle
mark new module's package NonNullApi
a53d702
@simonbasle
fix MicrometerListenerConfigurationTest
bd6eb5a
@simonbasle
test coverage of MicrometerListener
99642e2
@simonbasle
polish javadoc and simplify mono doOnNext path
0eaf2e6
@simonbasle simonbasle force-pushed the reactorMetricsMicrometerModule branch from 04f7c20 to 0eaf2e6 Compare April 19, 2022 09:27
@simonbasle simonbasle marked this pull request as ready for review April 19, 2022 09:57
@simonbasle simonbasle requested a review from a team as a code owner April 19, 2022 09:57
violetagg
violetagg reviewed Apr 19, 2022
View reviewed changes
violetagg
violetagg reviewed Apr 19, 2022
View reviewed changes
violetagg
violetagg reviewed Apr 19, 2022
View reviewed changes
@simonbasle simonbasle changed the title Introduce new module reactor-metrics-micrometer Introduce new module reactor-core-micrometer Apr 19, 2022
@simonbasle simonbasle merged commit cbd3913 into main Apr 20, 2022
@simonbasle simonbasle deleted the reactorMetricsMicrometerModule branch April 20, 2022 07:43
@simonbasle simonbasle mentioned this pull request May 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@violetagg violetagg violetagg approved these changes

@OlegDokuka OlegDokuka Awaiting requested review from OlegDokuka

Assignees

No one assigned

Labels

type/enhancement A general enhancement warn/deprecation This issue/PR introduces deprecations

Projects

None yet

Milestone

3.5.0-M2

Development

Successfully merging this pull request may close these issues.

3 participants

@simonbasle @violetagg @OlegDokuka