KEMBAR78
Refguide on mobile to use screen space optimally by tmyksj · Pull Request #3019 · reactor/reactor-core · GitHub
Skip to content

Conversation

@tmyksj
Copy link
Contributor

@tmyksj tmyksj commented Apr 16, 2022

Refs #3011

The reason which reference guide not using screen space optimally in portrait mode is normally from table and text overflow. This issue is also occur in a bit large window, such as width less than amount 1000px.

Below are the factors and how to resolve it:

header overflow

The header which has long word makes text overflow. e.g., "Sinks.many().unicast().onBackpressureBuffer(args?)".
So, add property overflow-wrap: break-word.

paragraph overflow

The long word in a paragraph makes text overflow.
So, add property overflow-wrap: break-word.

code in a patagraph overflow

To set white-space: nowrap causes overflow in narrow window because it blocks to break code text.
So, set it only when width >= 1280px.

table overflow (.tableblock, .admonitionblock, .colist)

The table width depends on the table content. The width will be larger than 100% if its content has wide width. So, this cause overflow.
Thus, set some properties to not have wide width, to not overflow.

refs:
https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap
https://developer.mozilla.org/en-US/docs/Web/CSS/table-layout
https://developer.mozilla.org/en-US/docs/Web/CSS/white-space


Also, I think it should be desirable to expand content area (and it seems separated #issue)...

@tmyksj tmyksj requested a review from a team as a code owner April 16, 2022 06:39
@simonbasle
Copy link
Contributor

@tmyksj thanks a bunch for the PR 👍

On my phone I'm still seeing smaller paragraphs for text and code snippet compared to tables like the metrics or kotlin section tables 😢

@simonbasle
Copy link
Contributor

NB: on Android, Chrome seems to be behaving a bit better. I'm usually using Firefox Mobile.

@tmyksj
Copy link
Contributor Author

tmyksj commented Apr 21, 2022

Ummm, I saw Edge, FireFox on Android but I cannot reproduce it...
Would you tell me CSS pixels of the window? It might depend on the width.

This commit fixes overflow of `code`, `attribution` in portrait mode.
@tmyksj
Copy link
Contributor Author

tmyksj commented Apr 30, 2022

I changed some css properties. I think it fixes when width >= amount 300px.

For more small width, I think we also need to expand content area. But < 300px is minor and I think it isn't core of this #issue. So, I think other #issue and RR are desirable. (with improvement of readability, such as table, code block. e.g., introducing of horizontal scroll may make it more readable.)

@simonbasle I would appreciate if you could re-review this.

@simonbasle
Copy link
Contributor

yeah this is looking better 👍
portrait mode on phone is not great for reading code anyway, but at least now the text block make use of all the space.
in landscape mode, similarly, the full horizontal space is used and then the code snippets become much more readable.
good job @tmyksj 🙇

@simonbasle simonbasle added this to the 3.5.0-M3 milestone May 2, 2022
@simonbasle simonbasle added the type/documentation A documentation update label May 2, 2022
@simonbasle simonbasle changed the title Use screen space optimally Refguide on mobile to use screen space optimally May 2, 2022
@simonbasle simonbasle merged commit 82301b1 into reactor:main May 2, 2022
@tmyksj
Copy link
Contributor Author

tmyksj commented May 2, 2022

Thank you very much 🙇

@tmyksj tmyksj deleted the 3011-useScreenSpaceOptimally branch May 2, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/documentation A documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants